From owner-cvs-all@FreeBSD.ORG Tue Nov 2 21:11:13 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0113016A4D0 for ; Tue, 2 Nov 2004 21:11:13 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61B8D43D31 for ; Tue, 2 Nov 2004 21:11:12 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 10523 invoked from network); 2 Nov 2004 21:11:12 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 2 Nov 2004 21:11:11 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA2LAuYP070948; Tue, 2 Nov 2004 16:11:08 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: David Xu Date: Tue, 2 Nov 2004 15:49:27 -0500 User-Agent: KMail/1.6.2 References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> <4186C114.1000004@freebsd.org> In-Reply-To: <4186C114.1000004@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411021549.27511.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:11:13 -0000 On Monday 01 November 2004 06:04 pm, David Xu wrote: > Not every important, I think I have another very important history > bug in hand, did you get my "fix famous libpthread conditional > variable race condition" mail ? :-) Oooo, can I test it please? We are still having problems with mono on HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 to libpthread but that seemed to make it worse. The problems seem to be that a signal handler is being run when the SYNCQ sflag is set (but the thread is not on a cv or a mutex queue), and the handler calls sem_post() which is supposed to be signal safe. sem_post() tries to lock a mutex and then bombs with the assertion failure. > David Xu > > Julian Elischer wrote: > > shuold there be an MFC date? > > > > David Xu wrote: > >> davidxu 2004-11-01 10:49:34 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libpthread/thread thr_private.h thr_sig.c Log: > >> Save cancelflags in signal frame, this fixes a problem that > >> a thread in pthread_cond_wait handled a signal can no longer > >> be canceled. > >> > >> Reviewed by: deischen > >> > >> Revision Changes Path > >> 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h > >> 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org