From owner-freebsd-bugs@freebsd.org Fri Feb 26 04:56:21 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 551085550DE for ; Fri, 26 Feb 2021 04:56:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dmy6Y1mPFz4lTL for ; Fri, 26 Feb 2021 04:56:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3C97A5550DD; Fri, 26 Feb 2021 04:56:21 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3C650554FCF for ; Fri, 26 Feb 2021 04:56:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dmy6Y1BYfz4lhg for ; Fri, 26 Feb 2021 04:56:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1BACC246CD for ; Fri, 26 Feb 2021 04:56:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11Q4uLh7087344 for ; Fri, 26 Feb 2021 04:56:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11Q4uL1L087343 for bugs@FreeBSD.org; Fri, 26 Feb 2021 04:56:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253862] prometheus_sysctl_exporter outputs invalid format Date: Fri, 26 Feb 2021 04:56:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: devinrsmith@protonmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 04:56:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253862 Bug ID: 253862 Summary: prometheus_sysctl_exporter outputs invalid format Product: Base System Version: 12.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: devinrsmith@protonmail.com It appears that /usr/sbin/prometheus_sysctl_exporter is outputting an inval= id prometheus format when used with the "-d" option. $ prometheus_sysctl_exporter -d | grep HELP | awk -F " " '{print $3}' | sor= t | uniq -c | sort | grep -v " 1 " 2 sysctl_vfs_zfs_arc_max 2 sysctl_vfs_zfs_arc_min 2 sysctl_vfs_zfs_l2arc_feed_again 2 sysctl_vfs_zfs_l2arc_feed_min_ms 2 sysctl_vfs_zfs_l2arc_feed_secs 2 sysctl_vfs_zfs_l2arc_headroom 2 sysctl_vfs_zfs_l2arc_noprefetch 2 sysctl_vfs_zfs_l2arc_norw 2 sysctl_vfs_zfs_l2arc_write_boost 2 sysctl_vfs_zfs_l2arc_write_max "Only one HELP line may exist for any given metric name." - https://github.com/prometheus/docs/blob/33f891f/content/docs/instrumenting/= exposition_formats.md#comments-help-text-and-type-information This is causing a downstream consumer to fail during parsing: $ grep node_exporter /var/log/messages Feb 25 20:43:51 prometheus node_exporter[46973]: level=3Derror ts=3D2021-02-26T04:43:51.646Z caller=3Dtextfile.go:209 collector=3Dtextfile msg=3D"failed to collect textfile data" file=3Dsysctl.prom err=3D"failed to= parse textfile data from \"/var/tmp/node_exporter/sysctl.prom\": text format pars= ing error in line 1974: second HELP line for metric name \"sysctl_vfs_zfs_l2arc_norw\"" It's easy enough to workaround by just excluding the "-d" flag, but it woul= d be nice for prometheus to gather the additional context that "-d" provides. --=20 You are receiving this mail because: You are the assignee for the bug.=