From nobody Fri Jan 17 12:26:55 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YZJrc41KKz5kvFj; Fri, 17 Jan 2025 12:26:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YZJrb60tYz3TLY; Fri, 17 Jan 2025 12:26:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737116815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w0iCT3frMAmEbZ5qY08KCoUOBW4E40spQRsWXvITiYs=; b=pBeFvdBRJS52jVFntbP1Hy4GtGc4lWbOBuK6xl2/BvsGaRAykMkBSeG9cnhWNjlmpY068X lGw1TKRXTeRZ+/H9PeW2cRhGrflmxBJrujzx+0l3hBw0VLxLmCMFPXpeuG6vzKnB7l8dmS pQuZRITz5FsoWpMpJXZ6d7scwwrXE9uVArEUrPxX9iTgzV9VDpvofP/pDgHpEdJU0Kvnqj TOdjXGNyuyIWaN3XHtgY883VBjUM3UU4s18POicpsmhkDJQNRXVuXzXMGHZ7Cf2W9C51a/ qgctt6HEQcwjazuO8oHK1rh3E+vuDLHDAGVsDTubA6+QFKeCkIluhNR0uok39w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737116815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w0iCT3frMAmEbZ5qY08KCoUOBW4E40spQRsWXvITiYs=; b=w7KPkgFluj42X+xx5Hju4tz5NdopD3ZEHS4A82Puj1AAnOYzQ7O+4qKZp5SxRVDkb5iNLA appmIe+1CXTbeoRmn6DoOPCWvBnVlL/QAoMAOfceShUNyzBss6grbcANz5F2nuLF27A7SE bQzzZQyj8ZF1bnThgFbSADjCbapanTyq0TvXArWZuWTU7Hr4CawQzE4wOeulH7DdkxUvmC /pSb0B3Hd9wVm4FGevD/Bsp3itWDnpDQGHcqPpuKNAEmCOFm+hVDovcnnImW90f1x3F2eT bwAKARHXQyVK644P7mDOD1M6onx7zTUP3TyvzVcV7PTix5n4dTN/8md7MjnkMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737116815; a=rsa-sha256; cv=none; b=drcaNYMQGRUKGWP7U3C4Gm29DLuamc6o7ff7rGnxYxCECLL/mZzLMda+hFBEeAThkyrZIh S/XfST42jWkK4+d1O+ElI6dPd0v/M2kPC6mm07mYZefVXYMiM1sEONSsVvEFrSKkP8Oxvi rJJsOvPToJ9AGJA3irV6v0D5Ygx8cJB6W8e3hzrar+nPPjBa4HvoJXYDhPvKaLKu40wO9F XKwzjVAuutuHVIEW7dS1slPu4xqow5TpwGnamIaL+RIbsJj73dt9fhVl8X58QOHxwW8uf5 FXGLrbusSx+QQivbslURzvvxG7Y0/nTJxV7irDw1Srxxe/xJBeFVwul2drQNrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YZJrb4KdJz2Wk; Fri, 17 Jan 2025 12:26:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50HCQtOv051678; Fri, 17 Jan 2025 12:26:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50HCQtFU051675; Fri, 17 Jan 2025 12:26:55 GMT (envelope-from git) Date: Fri, 17 Jan 2025 12:26:55 GMT Message-Id: <202501171226.50HCQtFU051675@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 08eab7b3eb49 - stable/13 - osd: Constify signature of osd_register() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 08eab7b3eb49034add710863760acc8406649eed Auto-Submitted: auto-generated The branch stable/13 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=08eab7b3eb49034add710863760acc8406649eed commit 08eab7b3eb49034add710863760acc8406649eed Author: Olivier Certner AuthorDate: 2024-07-01 17:10:47 +0000 Commit: Olivier Certner CommitDate: 2025-01-17 12:24:48 +0000 osd: Constify signature of osd_register() This makes it clear that 'methods' (if not NULL) points to an array that won't be modified. Internally, this array is indeed copied into the given OSD type's larger array of all methods for all slots. Reviewed by: jamie Approved by: markj (mentor) MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46886 (cherry picked from commit 4a26b63145a5e18610aa9050262e3b4f75aa7117) --- share/man/man9/osd.9 | 4 ++-- sys/kern/kern_osd.c | 2 +- sys/sys/osd.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/share/man/man9/osd.9 b/share/man/man9/osd.9 index 82f279ef17f4..22fa2d681e3b 100644 --- a/share/man/man9/osd.9 +++ b/share/man/man9/osd.9 @@ -23,7 +23,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd April 26, 2016 +.Dd October 07, 2024 .Dt OSD 9 .Os .Sh NAME @@ -49,7 +49,7 @@ .Fo osd_register .Fa "u_int type" .Fa "osd_destructor_t destructor" -.Fa "osd_method_t *methods" +.Fa "const osd_method_t *methods" .Fc .Ft void .Fo osd_deregister diff --git a/sys/kern/kern_osd.c b/sys/kern/kern_osd.c index df5f771ac04e..553d809259d1 100644 --- a/sys/kern/kern_osd.c +++ b/sys/kern/kern_osd.c @@ -91,7 +91,7 @@ osd_default_destructor(void *value __unused) } int -osd_register(u_int type, osd_destructor_t destructor, osd_method_t *methods) +osd_register(u_int type, osd_destructor_t destructor, const osd_method_t *methods) { void *newptr; u_int i, m; diff --git a/sys/sys/osd.h b/sys/sys/osd.h index 498cad5064f9..5d59ce5a3d9a 100644 --- a/sys/sys/osd.h +++ b/sys/sys/osd.h @@ -55,7 +55,7 @@ typedef void (*osd_destructor_t)(void *value); typedef int (*osd_method_t)(void *obj, void *data); int osd_register(u_int type, osd_destructor_t destructor, - osd_method_t *methods); + const osd_method_t *methods); void osd_deregister(u_int type, u_int slot); int osd_set(u_int type, struct osd *osd, u_int slot, void *value);