From owner-cvs-all Thu Dec 3 19:43:31 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA12857 for cvs-all-outgoing; Thu, 3 Dec 1998 19:43:31 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from nagual.pp.ru (lsd.relcom.eu.net [193.125.27.73]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA12844; Thu, 3 Dec 1998 19:43:27 -0800 (PST) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.9.1/8.9.1) id GAA33750; Fri, 4 Dec 1998 06:43:12 +0300 (MSK) (envelope-from ache) Message-ID: <19981204064311.A31118@nagual.pp.ru> Date: Fri, 4 Dec 1998 06:43:11 +0300 From: "Andrey A. Chernov" To: Matt Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c Mail-Followup-To: Matt Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <199812032023.MAA02215@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <199812032023.MAA02215@freefall.freebsd.org>; from dillon@FreeBSD.ORG on Thu, Dec 03, 1998 at 12:23:21PM -0800 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, Dec 03, 1998 at 12:23:21PM -0800, Matt Dillon wrote: > dillon 1998/12/03 12:23:21 PST > > Modified files: > sys/netinet icmp_var.h ip_icmp.c tcp_input.c > udp_usrreq.c Please remove or #ifdef KERNEL #include "opt_icmp_bandlim.h" from icmp_var.h, this file sometimes used in userland applications which are broken now. Function badport_badlim should also be removed of KERNEL #ifdefed. Basically I dislike idea of touching icmp_var.h at all, could you add separate include file for this stuff, please? -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message