From owner-cvs-all  Tue Dec 12 14:29:58 2000
From owner-cvs-all@FreeBSD.ORG  Tue Dec 12 14:29:54 2000
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from netau1.alcanet.com.au (ntp.alcanet.com.au [203.62.196.27])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8377637B400; Tue, 12 Dec 2000 14:29:52 -0800 (PST)
Received: from mfg1.cim.alcatel.com.au (mfg1.cim.alcatel.com.au [139.188.23.1])
	by netau1.alcanet.com.au (8.9.3 (PHNE_18979)/8.9.3) with ESMTP id JAA02214;
	Wed, 13 Dec 2000 09:27:12 +1100 (EDT)
Received: from gsmx07.alcatel.com.au by cim.alcatel.com.au
 (PMDF V5.2-32 #37645) with ESMTP id <01JXNFSV4AUOEAFTIY@cim.alcatel.com.au>;
 Wed, 13 Dec 2000 09:27:01 +1100
Received: (from jeremyp@localhost)	by gsmx07.alcatel.com.au (8.11.0/8.11.0)
 id eBCMR4Q84866; Wed, 13 Dec 2000 09:27:04 +1100 (EST envelope-from jeremyp)
Content-return: prohibited
Date: Wed, 13 Dec 2000 09:27:03 +1100
From: Peter Jeremy <peter.jeremy@alcatel.com.au>
Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern
In-reply-to: <200012122109.QAA53213@khavrinen.lcs.mit.edu>; from
 wollman@khavrinen.lcs.mit.edu on Tue, Dec 12, 2000 at 04:09:16PM -0500
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, cvs-all@FreeBSD.ORG,
	cvs-committers@FreeBSD.ORG
Mail-followup-to: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>,
 Poul-Henning Kamp <phk@critter.freebsd.dk>, cvs-all@FreeBSD.ORG,
 cvs-committers@FreeBSD.ORG
Message-id: <20001213092703.Y69646@gsmx07.alcatel.com.au>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-disposition: inline
User-Agent: Mutt/1.2.5i
References: <Pine.LNX.4.21.0012121301400.26829-100000@zeppo.feral.com>
 <52595.976655244@critter> <200012122109.QAA53213@khavrinen.lcs.mit.edu>
Sender: jeremyp@gsmx07.alcatel.com.au
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On 2000-Dec-12 16:09:16 -0500, Garrett Wollman <wollman@khavrinen.lcs.mit.edu> wrote:
><<On Tue, 12 Dec 2000 22:07:24 +0100, Poul-Henning Kamp <phk@critter.freebsd.dk> said:
>
>> I did, and they were unneeded at the time (or current would have been
>> broken since Oct 29th.)
>
>``unneeded'' != ``compiles OK without the header''.
>
>There are many instances of the latter which result from brokenness in
>the headers.

I suspect Poul-Henning's script needs to have improved handling of
two cases:
1) The include file is only required with some combination of
   #defines.
2) Where a file is `unneeded' because it is implicitly included via
   another header file, the chain via which the file is includes needs
   to be noted and manually examined.

Both these situations have occurred in the last few months.  In the
latter case, finding out why something broke can be messy.

Peter


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message