Date: Wed, 13 Dec 2000 09:27:03 +1100 From: Peter Jeremy <peter.jeremy@alcatel.com.au> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern Message-ID: <20001213092703.Y69646@gsmx07.alcatel.com.au> In-Reply-To: <200012122109.QAA53213@khavrinen.lcs.mit.edu>; from wollman@khavrinen.lcs.mit.edu on Tue, Dec 12, 2000 at 04:09:16PM -0500 References: <Pine.LNX.4.21.0012121301400.26829-100000@zeppo.feral.com> <52595.976655244@critter> <200012122109.QAA53213@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2000-Dec-12 16:09:16 -0500, Garrett Wollman <wollman@khavrinen.lcs.mit.edu> wrote: ><<On Tue, 12 Dec 2000 22:07:24 +0100, Poul-Henning Kamp <phk@critter.freebsd.dk> said: > >> I did, and they were unneeded at the time (or current would have been >> broken since Oct 29th.) > >``unneeded'' != ``compiles OK without the header''. > >There are many instances of the latter which result from brokenness in >the headers. I suspect Poul-Henning's script needs to have improved handling of two cases: 1) The include file is only required with some combination of #defines. 2) Where a file is `unneeded' because it is implicitly included via another header file, the chain via which the file is includes needs to be noted and manually examined. Both these situations have occurred in the last few months. In the latter case, finding out why something broke can be messy. Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001213092703.Y69646>