Date: Thu, 27 Dec 2012 00:22:38 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Jilles Tjoelker <jilles@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244682 - head/bin/sh Message-ID: <20121226232238.GB1394@garage.freebsd.pl> In-Reply-To: <201212251417.qBPEHAQC070177@svn.freebsd.org> References: <201212251417.qBPEHAQC070177@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Y7xTucakfITjPcLV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 25, 2012 at 02:17:10PM +0000, Jilles Tjoelker wrote: > Author: jilles > Date: Tue Dec 25 14:17:09 2012 > New Revision: 244682 > URL: http://svnweb.freebsd.org/changeset/base/244682 >=20 > Log: > sh: Prefer strsignal() to accessing sys_siglist directly. > =20 > Accessing sys_siglist directly requires rtld to copy it from libc to th= e sh > executable's BSS. Also, strsignal() will put in the signal number for > unknown signals (FreeBSD-specific) so we need not do that ourselves. > =20 > Unfortunately, there is no function for sys_signame. Yes, that would be very handy. BTW. > + sigstr =3D strsignal(i); > + if (sigstr !=3D NULL) > + strcpy(statestr, sigstr); > else > strcpy(statestr, "Suspended"); When strsignal(3) can return NULL? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --Y7xTucakfITjPcLV Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDbhr4ACgkQForvXbEpPzSEvQCfZAMED/fI/aCwp3DGKTzBIWvO 2WIAn21SkxANp+UjbTHKk5iyGUSvyZYD =0bi7 -----END PGP SIGNATURE----- --Y7xTucakfITjPcLV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121226232238.GB1394>