From owner-svn-src-all@FreeBSD.ORG  Wed Dec 26 23:22:37 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BD30A55F;
 Wed, 26 Dec 2012 23:22:37 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id 7A5468FC08;
 Wed, 26 Dec 2012 23:22:36 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id DF9CA7CA;
 Thu, 27 Dec 2012 00:20:17 +0100 (CET)
Date: Thu, 27 Dec 2012 00:22:38 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Jilles Tjoelker <jilles@FreeBSD.org>
Subject: Re: svn commit: r244682 - head/bin/sh
Message-ID: <20121226232238.GB1394@garage.freebsd.pl>
References: <201212251417.qBPEHAQC070177@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="Y7xTucakfITjPcLV"
Content-Disposition: inline
In-Reply-To: <201212251417.qBPEHAQC070177@svn.freebsd.org>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Dec 2012 23:22:37 -0000


--Y7xTucakfITjPcLV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 25, 2012 at 02:17:10PM +0000, Jilles Tjoelker wrote:
> Author: jilles
> Date: Tue Dec 25 14:17:09 2012
> New Revision: 244682
> URL: http://svnweb.freebsd.org/changeset/base/244682
>=20
> Log:
>   sh: Prefer strsignal() to accessing sys_siglist directly.
>  =20
>   Accessing sys_siglist directly requires rtld to copy it from libc to th=
e sh
>   executable's BSS. Also, strsignal() will put in the signal number for
>   unknown signals (FreeBSD-specific) so we need not do that ourselves.
>  =20
>   Unfortunately, there is no function for sys_signame.

Yes, that would be very handy.

BTW.

> +		sigstr =3D strsignal(i);
> +		if (sigstr !=3D NULL)
> +			strcpy(statestr, sigstr);
>  		else
>  			strcpy(statestr, "Suspended");

When strsignal(3) can return NULL?

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--Y7xTucakfITjPcLV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlDbhr4ACgkQForvXbEpPzSEvQCfZAMED/fI/aCwp3DGKTzBIWvO
2WIAn21SkxANp+UjbTHKk5iyGUSvyZYD
=0bi7
-----END PGP SIGNATURE-----

--Y7xTucakfITjPcLV--