From owner-cvs-src Wed Feb 19 14:14:39 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A79A37B401; Wed, 19 Feb 2003 14:14:38 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5220143F75; Wed, 19 Feb 2003 14:14:37 -0800 (PST) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.5/8.12.1) with ESMTP id h1JMEanN042725 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Wed, 19 Feb 2003 14:14:36 -0800 (PST)?g (envelope-from sam@errno.com)œ X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange Message-ID: <0b4101c2d864$49cbafd0$52557f42@errno.com> From: "Sam Leffler" To: "Maxime Henrion" , , , References: <200302191833.h1JIXT2d013173@repoman.freebsd.org> Subject: Re: cvs commit: src/sys/pci if_xl.c Date: Wed, 19 Feb 2003 14:14:35 -0800 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > We should probably move all the other DMA map creations in > xl_attach() where we can really handle them failing, since > xl_init() is void and shouldn't fail. When I did the struct ifnet fixups I almost changed if_init from void to int to return an error code. Maybe it's not too late to do this before the REELNG_5 branch? Sam To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message