From owner-svn-src-all@FreeBSD.ORG  Thu Sep  3 12:12:40 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D5479106566C;
	Thu,  3 Sep 2009 12:12:40 +0000 (UTC)
	(envelope-from joerg@britannica.bec.de)
Received: from www.sonnenberger.org (www.sonnenberger.org [92.79.50.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 96AD28FC16;
	Thu,  3 Sep 2009 12:12:40 +0000 (UTC)
Received: from britannica.bec.de (www.sonnenberger.org [192.168.1.10])
	by www.sonnenberger.org (Postfix) with ESMTP id 0A193667A2;
	Thu,  3 Sep 2009 13:54:53 +0200 (CEST)
Received: by britannica.bec.de (Postfix, from userid 1000)
	id 2CA591BDD65; Thu,  3 Sep 2009 13:54:16 +0200 (CEST)
Date: Thu, 3 Sep 2009 13:54:16 +0200
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: svn-src-all@freebsd.org
Message-ID: <20090903115416.GB448@britannica.bec.de>
References: <200909020456.n824uUqQ082136@svn.freebsd.org>
	<20090902070808.GA1290@arthur.nitro.dk>
	<20090902084002.GA17325@nagual.pp.ru> <867hwgcwvo.fsf@ds4.des.no>
	<20090903084325.GA65192@nagual.pp.ru> <86zl9c9z05.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86zl9c9z05.fsf@ds4.des.no>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: des@freebsd.org
Subject: Re: svn commit: r196752 - head/lib/libc/stdtime
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Sep 2009 12:12:40 -0000

On Thu, Sep 03, 2009 at 11:08:26AM +0200, Dag-Erling Smørgrav wrote:
> @@ -65,6 +65,15 @@
>  .It "\&031\ EM \t032\ SUB \t033\ ESC \t034\ FS \t035\ GS"
>  .It "\&036\ RS \t037\ US \t177\ DEL"
>  .El
> +.Pp
> +.Em NOTE :
> +if the value passed to the
> +.Fn iscntrl
> +function is a
> +.Vt signed char ,
> +as is usually the case, it must be cast to an
> +.Vt unsigned char
> +to avoid sign-extension errors.
>  .Sh RETURN VALUES
>  The
>  .Fn iscntrl

This is actually not good enough. ISO C doesn't specify whether plain
char is signed or unsigned.

Also, isascii is the only exception to this rule, so the change for that
is wrong.

Joerg