From owner-freebsd-infiniband@freebsd.org Sat Feb 22 08:59:34 2020 Return-Path: Delivered-To: freebsd-infiniband@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A073255122; Sat, 22 Feb 2020 08:59:34 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48Pj1w5gFSz40xM; Sat, 22 Feb 2020 08:59:32 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 7E66B2602DF; Sat, 22 Feb 2020 09:59:29 +0100 (CET) Subject: Re: [PATCH]: ipoib with mlx4 initialisation ordering To: Andreas Kempe , freebsd-net@freebsd.org, freebsd-infiniband@freebsd.org References: <20200222004838.GA22659@moira.hest-guild.se> From: Hans Petter Selasky Message-ID: Date: Sat, 22 Feb 2020 09:59:23 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200222004838.GA22659@moira.hest-guild.se> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48Pj1w5gFSz40xM X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.96 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-2.66)[ip: (-9.21), ipnet: 2a01:4f8::/29(-2.54), asn: 24940(-1.55), country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-infiniband@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Infiniband on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2020 08:59:34 -0000 On 2020-02-22 01:48, Andreas Kempe wrote: > Hello everyone, > > We have had issues with our machine using IPoIB on FreeBSD with the > mlx4 driver. The machine would hang on shutdown. > > We traced the issue to IPoIB registering multicast groups that > increase the reference count of the port in the ib_multicast client. > When shutting down the machine, the kernel tore down the ib_multicast > before it tore down IPoIB, causing it to wait forever for the > references to disappear before it deleted the multicast client. > > This issue can be remedied by changing the initialisation of the IPoIB > module to happen after the mlx4 driver is initialised. By doing this, > all multicast groups will be cleaned up before the ib_multicast client > is destroyed. > > See patch attached. Sponsored by: Lysator ACS > > Cordially, > Andreas Kempe I'll have a closer look on Monday. --HPS