Date: Tue, 30 Aug 2016 15:05:44 +0200 From: =?UTF-8?B?UGF3ZcWCIFDEmWthbGE=?= <pawel@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420924 - head/audio/gmpc-magnatune Message-ID: <20160830150544.4f57349e@FreeBSD.org> In-Reply-To: <8fe3e649-e929-c037-6193-c23b685a1222@marino.st> References: <201608261504.u7QF46B1060800@repo.freebsd.org> <074eb0ed-40bb-e188-4754-3edde192db12@marino.st> <8fe3e649-e929-c037-6193-c23b685a1222@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi John, On 2016-08-29 22:20 -0500, John Marino <freebsd.contact@marino.st> wrote: >On 8/29/2016 22:17, John Marino wrote: >> On 8/26/2016 10:04, Pawel Pekala wrote: =20 >>> Author: pawel >>> Date: Fri Aug 26 15:04:06 2016 >>> New Revision: 420924 >>> URL: https://svnweb.freebsd.org/changeset/ports/420924 >>> >>> Log: >>> - Convert to USES=3Dsqlite >>> - Convert to PLIST_FILES, only 2 items in plist >>> - Register proxy dependencies found by stage-qa >>> >>> Deleted: >>> head/audio/gmpc-magnatune/pkg-plist >>> Modified: >>> head/audio/gmpc-magnatune/Makefile >>> >>> Modified: head/audio/gmpc-magnatune/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> >>> --- head/audio/gmpc-magnatune/Makefile Fri Aug 26 14:58:33 2016 >>> (r420923) >>> +++ head/audio/gmpc-magnatune/Makefile Fri Aug 26 15:04:06 2016 >>> (r420924) >>> @@ -14,13 +14,17 @@ LICENSE=3D GPLv2+ >>> LICENSE_FILE=3D ${WRKSRC}/COPYING >>> >>> LIB_DEPENDS=3D libmpd.so:audio/libmpd \ >>> - libsqlite3.so:databases/sqlite3 >>> + libfreetype.so:print/freetype2 \ >>> + libfontconfig.so:x11-fonts/fontconfig >>> BUILD_DEPENDS=3D ${LOCALBASE}/libdata/pkgconfig/gmpc.pc:audio/gmpc >>> RUN_DEPENDS=3D gmpc:audio/gmpc >>> >>> +USES=3D gettext gmake libtool pkgconfig sqlite >>> +USE_GNOME=3D cairo gdkpixbuf2 glib20 gtk20 intltool libglade2 >>> GNU_CONFIGURE=3D yes >>> -USE_GNOME=3D intltool glib20 gtk20 libglade2 >>> -USES=3D gettext gmake libtool pkgconfig >>> INSTALL_TARGET=3D install-strip >>> >>> +PLIST_FILES=3D lib/gmpc/plugins/magnatuneplugin.so \ >>> + share/gmpc/plugins/magnatune/magnatune.png >>> + >>> .include <bsd.port.mk> >>> =20 >> >> Pawel, >> Many library dependencies were added. That requires a PORTREVISION >> bump!=20 > >actually, I meant to write this about audio/gmpc but it appears=20 >audio/gmpc-magnatune had the same issue. Dependencies added in both ports showed up in poudriere logs so they are be definition proxy. So my commits register that this packages link to particular libraries, no new dependencies are added - they are already pulled in by packages needed to build port. I do check for new dependencies by comparing poudriere vs live build stage-qa outputs to find new ones, but it's not the case here. --=20 pozdrawiam / with regards Pawe=C5=82 P=C4=99kala
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160830150544.4f57349e>