From owner-freebsd-current@FreeBSD.ORG Thu Jun 23 20:21:59 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 402671065673 for ; Thu, 23 Jun 2011 20:21:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 994318FC0A for ; Thu, 23 Jun 2011 20:21:58 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p5NKLs0e020503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 23 Jun 2011 23:21:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p5NKLs0Y029734; Thu, 23 Jun 2011 23:21:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p5NKLrwX029733; Thu, 23 Jun 2011 23:21:53 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 23 Jun 2011 23:21:53 +0300 From: Kostik Belousov To: obrien@freebsd.org, freebsd-current@freebsd.org Message-ID: <20110623202153.GS48734@deviant.kiev.zoral.com.ua> References: <20110623163109.GA508@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a0hUfxJ20zFHaLM9" Content-Disposition: inline In-Reply-To: <20110623163109.GA508@dragon.NUXI.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Subject: Re: Thoughts on TMPFS no longer being considered "highly experimental" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 20:21:59 -0000 --a0hUfxJ20zFHaLM9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2011 at 09:31:09AM -0700, David O'Brien wrote: > Does anyone object to this patch? >=20 > David Wolfskill and I have run TMPFS on a number of machines for two > years with no problems. >=20 > I may have missed something, but I'm not aware of any serious PRs on > TMPFS either. >=20 >=20 > Index: tmpfs_vfsops.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- tmpfs_vfsops.c (revision 221113) > +++ tmpfs_vfsops.c (working copy) > @@ -155,9 +155,6 @@ tmpfs_mount(struct mount *mp) > return EOPNOTSUPP; > } > =20 > - printf("WARNING: TMPFS is considered to be a highly experimental " > - "feature in FreeBSD.\n"); > - > vn_lock(mp->mnt_vnodecovered, LK_SHARED | LK_RETRY); > error =3D VOP_GETATTR(mp->mnt_vnodecovered, &va, mp->mnt_cred); > VOP_UNLOCK(mp->mnt_vnodecovered, 0); The things I am aware of: - there is a races on the lookup. They were papered over in r212305, but the bug was not really fixed, AFAIR. - the tmpfs does double-buffering for the mapped vnodes. This is quite insulting for the memory-backed fs, isn't it ? I have a patch, but it is still under review. - I believe Peter Holm has more test cases that fails with tmpfs. He would have more details. I somewhat remember some panic on execve(2) the binary located on tmpfs. Removing the warning will not make the issues coming away. --a0hUfxJ20zFHaLM9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk4DoGEACgkQC3+MBN1Mb4j9wwCg0V37VuQUw5heAl/Z/iAlO+h0 SmAAoJf/+BF533SS0hUjGsscsSAqUApX =5GKO -----END PGP SIGNATURE----- --a0hUfxJ20zFHaLM9--