From owner-freebsd-net@FreeBSD.ORG Mon Jun 9 21:25:13 2014 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2D8A93D3 for ; Mon, 9 Jun 2014 21:25:13 +0000 (UTC) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id DF259245D for ; Mon, 9 Jun 2014 21:25:12 +0000 (UTC) Received: from lgwl-lstewart2.corp.netflix.com (unknown [69.53.237.72]) by lauren.room52.net (Postfix) with ESMTPSA id 3CE017E8C2; Tue, 10 Jun 2014 07:25:10 +1000 (EST) Message-ID: <53953725.7060604@freebsd.org> Date: Mon, 09 Jun 2014 14:25:09 +1000 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: hiren panchasara Subject: Re: ECN marking implenetation for dummynet References: <533BF902.7010506@sfc.wide.ad.jp> <539570F8.2010105@freebsd.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.8 required=5.0 tests=DATE_IN_PAST_12_24, UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net Cc: "net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jun 2014 21:25:13 -0000 On 06/09/14 18:47, hiren panchasara wrote: > On Mon, Jun 9, 2014 at 1:31 AM, Lawrence Stewart wrote: >> On 6/8/2014 9:07 PM, hiren panchasara wrote: > >>> I wish to MFC this change and following actual dctcp changes (which >>> I'll commit to -head in coming weeks) to 10. >>> >>> Let me know if there is any objection to it. >> >> >> Please don't MFC the DCTCP stuff until I've had a chance to consider the KPI >> changes. Prodding me to do so is likely a good idea. > > I am in no rush to MFC. But I didn't quite get what you are talking > about wrt KPI changes. Unless Midori's DCTCP work has changed significantly since I first reviewed it in 2013, it changes the modular congestion control KPI. I'd like to review the work again but don't want to delay it getting into head because I'm super busy. Just asking that it not be MFCed before I've given it a review. Cheers, Lawrence