From nobody Tue May 3 11:21:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A229B1AB56DC; Tue, 3 May 2022 11:21:57 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KsyGY47Jhz4kXW; Tue, 3 May 2022 11:21:57 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651576917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gzHFCdJFiRLvCR207T+SqdgF4S6oXDfdBHl2BW/nSWc=; b=oAPlbzwL+5sztc0urovz/QKp0X4LXisR5GehDJCfjiiFihbz7bp18O7kJzjwNp01BZT37X j8TUtiH8+at6mLpz8dygyX43XFTI9K86MWW06SQSVFQqu87sfOXFRygjAw3i/3i2r1ROuH 5dk0+m4VvxSNN7re9JOgIM2vspNUDEiiP6k6Sk4TUHfqXShVfphXsZENGS06++VHirBrlp PuI3TQMYIYBJfdEBnWvXZhffKBIwTDx6NqbGDrHp1P+vVwH5GLMFjpR4iB+AZsWuT0+AlI U369GBjw/gGjpM+DwiaUjXVd5NIFxA2NaHHnr7zYdfxBV5I8e9rNSPoDi5Mefw== Received: from [IPV6:2601:405:4a00:acd:1c8c:81a2:77c0:c9b5] (unknown [IPv6:2601:405:4a00:acd:1c8c:81a2:77c0:c9b5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: nwhitehorn/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4215625976; Tue, 3 May 2022 11:21:57 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Message-ID: <703c743c-9a4f-7ed5-8833-df43eb015cc6@freebsd.org> Date: Tue, 3 May 2022 07:21:56 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: git: cda31e734925 - main - xhci(4): Ensure the so-called data toggle gets properly reset. Content-Language: en-US To: Hans Petter Selasky , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202204211502.23LF2g2L010181@gitrepo.freebsd.org> <7af2c933-c907-6da0-1ea2-5e9afba50f78@freebsd.org> From: Nathan Whitehorn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651576917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gzHFCdJFiRLvCR207T+SqdgF4S6oXDfdBHl2BW/nSWc=; b=duTT5vlWMb9a257Yv2GuKgUhPCShIPqTyp3jYr/PMTHt879FDRdAK4m6AZrroLFLQveDL6 Bm9s3eAO+CMAQLdlyMPvjp0XZOuuHPjFWzObHL5yZGd8DHYWBpbAx3EI+faHarKh4+UVop AewsU/wEp2aBj+5HG2B6ehxmtPfkHks+PGo9uoN1+xONnh8xMES08xM0HI7/ol52g/PPsM XfBO7z8fP4A+Ur4LZri407wAGpYr6McIKoy+9pE8eyDrfx2RGlpnqjQjCVLLfJ4cMoXtYi 6s9hMNXBcY1WRJZ+/WAYNj+vtAfvHyENgiMPjTqp/x6Zg60pSWY8sPA5QIYLXg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651576917; a=rsa-sha256; cv=none; b=UwR117j5/6E9EeCYCRRbpvI4xGwo6x5yOpSoAzFCDqlWV5VhbtnYAieFQXMLHdZ2ETem/G xj0zfJmdU34pdiblF9SnQQ+XZgUzpp5S7Y9yUqcIwI9EbV/qRZIJmbR3xiNCaj/n7Nkh+9 2/A9fUZxPJq9CLg79nfQMNLYRL0D07U9C3ao2krKRVMuIPD1KIV8tI3QM/Guq+G1jSfQVv Sf+mNVE6v1FuR/33MQitZ3oL2zFFoNAuKMzoaaGztaoxtt2xcKbE9oxS4MoWaHzxIqUfmw L72oW1PcAr0djWkRW1zG36Q6SCRBFlBJomejts550Xj4mDBObA9XjlkDBfTCYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 5/3/22 02:40, Hans Petter Selasky wrote: > On 5/3/22 00:25, Nathan Whitehorn wrote: >> After this change, I cannot use devices attached to the USB 3 hub in >> my Dell monitor anymore. The hub appears properly, but any device >> plugged into it just leaves this in dmesg: >> ugen0.3: at usbus0 (disconnected) >> >> Note that there is no corresponding connected message or anything else. >> >> This is with an AMD XHCI controller: >> xhci0@pci0:2:0:0:       class=0x0c0330 rev=0x02 hdr=0x00 >> vendor=0x1022 device=0x43bb subvendor=0x1b21 subdevice=0x1142 >>      vendor     = 'Advanced Micro Devices, Inc. [AMD]' >>      device     = '300 Series Chipset USB 3.1 xHCI Controller' >> > > > Hi Nathan, > > There is an ongoing discussion at (where you may upload USB debug logs > from the XHCI controller). > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262882 > > Can you try to "usbreset -d ugenX.Y" where ugenX.Y corresponds to the > address of the parent USB HUB for these devices. Do the devices come > back? > > I'm currently mostly testing on Intel chipsets, and don't see any such > issues! > > I believe the patch is correct, but maybe needs to be adapted to AMD's > XHCI controllers. > > --HPS > Yes, resetting the hub makes the devices appear and work. I'll add relevant details to the bug -- happy to test or investigate patches as well. -Nathan