From owner-p4-projects Sun Dec 22 19:13:35 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id AF46637B406; Sun, 22 Dec 2002 19:13:33 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47CAF37B401 for ; Sun, 22 Dec 2002 19:13:33 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8AFE043EE8 for ; Sun, 22 Dec 2002 19:13:32 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id gBN3DVuB072715; Sun, 22 Dec 2002 20:13:31 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 22 Dec 2002 20:12:40 -0700 (MST) Message-Id: <20021222.201240.16049170.imp@bsdimp.com> To: marcel@xcllnt.net Cc: perforce@freebsd.org Subject: Re: PERFORCE change 22626 for review From: "M. Warner Losh" In-Reply-To: <20021222234933.GB1414@athlon.pn.xcllnt.net> References: <200212221927.gBMJR0si013191@repoman.freebsd.org> <20021222.151026.100645554.imp@bsdimp.com> <20021222234933.GB1414@athlon.pn.xcllnt.net> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20021222234933.GB1414@athlon.pn.xcllnt.net> Marcel Moolenaar writes: : On Sun, Dec 22, 2002 at 03:10:26PM -0700, M. Warner Losh wrote: : > In message: <200212221927.gBMJR0si013191@repoman.freebsd.org> : > Marcel Moolenaar writes: : > : static int : > : sio_pccard_detach(dev) : > : device_t dev; : > : { : > : - return (siodetach(dev)); : > : + /* XXX broken */ : > : } : > : > This is clearly not acceptible. : : I completely fail to see why. I have to get a job done and as long as : I don't commit it to CVS I don't see why I cannot break anything that's : not immediately relevant to ia64 or to the job at hand. The primary : reason for this kind of axing is that I cannot test it at all and it : can only create bugs if I try to preserve it. It's much better to get : rid of it and spend the extra effort when it's being restored. A second : reason why I don't worry about it now is that it's not specific to : pccard anymore. OK. I guess I should have been less upset. So long as at the end of the day I can pop out my sio card from my cardbus/pccard slot and the device goes away properly, I'm happy. Part of the reason I got upset is that I was going to try to integrate your changes to sio into my tree and try to give it a test in my environment. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message