From owner-cvs-all Mon Mar 3 12:33:29 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F40F37B405 for ; Mon, 3 Mar 2003 12:33:27 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 4A31543F85 for ; Mon, 3 Mar 2003 12:33:26 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 78630 invoked by uid 1000); 3 Mar 2003 20:33:26 -0000 Date: Mon, 3 Mar 2003 12:33:26 -0800 (PST) From: Nate Lawson To: Jeff Roberson Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_default.c In-Reply-To: <20030303151051.F72102-100000@mail.chesapeake.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 3 Mar 2003, Jeff Roberson wrote: > On Mon, 3 Mar 2003, Nate Lawson wrote: > > Modified files: > > sys/kern vfs_default.c > > Log: > > Pick up one file missed in the previous vprint() cleanup > > > Hey, good work here. Do you think there would be any way to use the > vnode's char name in the generic sync routine? There are a few other > places where we msleep that could use a more specific name as well. Interesting idea but how would you suggest compressing that to 6 chars? I assume "show lockedvnodes" will always be supreme? And when I just glanced at the implementation of "show lockedvnodes", I noticed: mtx_lock(&mountlist_mtx); How can this be correct? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message