From owner-freebsd-stable@FreeBSD.ORG Thu Nov 17 13:46:12 2005 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from [127.0.0.1] (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id BD21316A41F; Thu, 17 Nov 2005 13:46:10 +0000 (GMT) (envelope-from davidxu@freebsd.org) Message-ID: <437C89A7.9040708@freebsd.org> Date: Thu, 17 Nov 2005 21:46:15 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.7.10) Gecko/20050806 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200511161623.38494.jhb@freebsd.org> In-Reply-To: <200511161623.38494.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@freebsd.org, current@freebsd.org Subject: Re: [PATCH] nve(4) locking cleanup X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2005 13:46:12 -0000 John Baldwin wrote: >I have a patch for nve(4) which fixes at least one known LOR in the driver and >generally fixes up the locking. If you have an nve(4) card that currently >works, please test this patch to make sure it doesn't break anything. If you >have an nve(4) card that doesn't work, this patch probably won't help. > >http://www.FreeBSD.org/~jhb/patches/nve_locking.patch > > > After this patch is applied, I got: nve0: port 0xb400-0xb407 mem 0xec000000-0xec000fff irq 20 at device 5.0 on pci0 nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: Ethernet address 00:04:61:fe:fb:7f nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held miibus0: on nve0 ciphy0: on miibus0 nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held nve0: nve_oslockacquire: normal mutex not held nve0: nve_oslockrelease: normal mutex not held ciphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 1000baseT-FDX, auto nve0: Ethernet address: 00:04:61:fe:fb:7f of course, it does not work, it had never worked. David Xu