Date: Sat, 5 Dec 2020 04:33:07 +0300 From: Yuri Pankov <yuripv@yuripv.dev> To: Thomas Munro <thomas.munro@gmail.com>, Baptiste Daroussin <bapt@freebsd.org> Cc: hackers@freebsd.org Subject: Re: locale-related review, wcwidth() data Message-ID: <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev> In-Reply-To: <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com> References: <559840f6-ee81-1303-2986-1eafb2104e1b@yuripv.dev> <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thomas Munro wrote:
> On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt@freebsd.org> wrote:
>> I do like what I see here, the only reason I haven't review is that I can't
>> test, since the last modification from hrs@ in the locale generation tools each
>> time I try to regenerate the locales it fails.
>
> During install? I noticed that too but wasn't sure of the correct fix, perhaps:
>
> diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
> index 76fff6acb17..b6ae2feadac 100644
> --- a/tools/tools/locale/Makefile
> +++ b/tools/tools/locale/Makefile
> @@ -95,7 +95,7 @@ install: install-${t}
> install-${t}:
> cd ${LOCALESRCDIR}/${t} && \
> rm -f Makefile *.src && \
> - install -c ${t}/* ${LOCALESRCDIR}/${t}
> + install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
> . endif
> .endfor
Makes sense.
BTW, to test what is in this review, you don't need the install target
-- new 'width' target depends only on cldr posix data itself, and
modifies etc/final-maps/widths.txt directly.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14fbfd11-a5fa-4e7e-422c-33738364c58d>