From owner-freebsd-hackers@freebsd.org Sat Dec 5 01:33:11 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A91374B18A5 for ; Sat, 5 Dec 2020 01:33:11 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CnsXR3CyDz4Y1Z for ; Sat, 5 Dec 2020 01:33:11 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: by mailman.nyi.freebsd.org (Postfix) id 6E74C4B18A4; Sat, 5 Dec 2020 01:33:11 +0000 (UTC) Delivered-To: hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E3C94B18A3 for ; Sat, 5 Dec 2020 01:33:11 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CnsXR2PLsz4Xsb; Sat, 5 Dec 2020 01:33:10 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 14B0258046E; Fri, 4 Dec 2020 20:33:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 04 Dec 2020 20:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.dev; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=E EVUN9aUJDAxm/EJMN8rLwKS24/aX6MCc7f4WBTwmcA=; b=Xu25nrXAlqHrRG5DZ U657Wl8MxlHWFItd1ou526n1LI2Q4xFRA8ZumSEULFZA2X8mmJQwyA4+bBPfz0HP 4JYqxFdiMJNhOBdxUEYkxuytTNnbTYGCbvgs1B5/C0A2se4f3BBHWXCCgqzP/7Z5 ZYLPEtBHc0Pvc3Mhlx8VlEzf7iQykHn5XUdUKL2ojzWGsKzjf4vlj93OSqfuuY7a gnuwQ4rNPgEZijGpGo3iDjZdHjAJry2l/5fFPNRDi/Wv0gnvknD6K2ZwC3yXHzjQ sC2W0A10Vt/Eu15bu1dYRjMEzEXwLWzt0lz8LSxTlsC1u4GuWBFmhhrvNdp5XLOq nrtiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EEVUN9aUJDAxm/EJMN8rLwKS24/aX6MCc7f4WBTwm cA=; b=pseiFZquDFJX1pSm3OQWzcKKG+caKw5qwWo2igxFA5jGi6fk6BvWDWUTb vqAke2iMT6Q4wFrqJuz4zBZ2AcbwPZZqwKf+MT4ZKWTjMM2odxKH6BI/63gO+QIP o8boOb8Y7zEXxVHWXwCbhveiq0tOol1wd36RSIIU4MPw1jp0C8RF1gKzyF8Rebeh R/O9Fooxf0C1Zwl5u+sIymTFYQ6Z5hZX9ILPPl6DPqHdYmqBdUFpdFD5oQH++/LN yMHGx26uSxONYNovqaSKgqsR0igYigAJ6C2U/vq0EttiU71nkC9y1Z6Hbm8wAAJ2 /BtAibPHJq16An8DsipjgTT/JoIUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiledgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepjghurhhi ucfrrghnkhhovhcuoeihuhhrihhpvheshihurhhiphhvrdguvghvqeenucggtffrrghtth gvrhhnpeffhedvkeegieejveelvdffgfevueevgffgjefhleeuueevtedvvddvgfeiteff teenucfkphepledurddvgedtrdduvdegrdduheejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhephihurhhiphhvseihuhhrihhpvhdruggvvh X-ME-Proxy: Received: from [192.168.1.6] (unknown [91.240.124.157]) by mail.messagingengine.com (Postfix) with ESMTPA id 03B7B240059; Fri, 4 Dec 2020 20:33:08 -0500 (EST) Subject: Re: locale-related review, wcwidth() data To: Thomas Munro , Baptiste Daroussin Cc: hackers@freebsd.org References: <559840f6-ee81-1303-2986-1eafb2104e1b@yuripv.dev> <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> From: Yuri Pankov Message-ID: <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev> Date: Sat, 5 Dec 2020 04:33:07 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CnsXR2PLsz4Xsb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_RCPT(0.00)[]; REPLY(-4.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2020 01:33:11 -0000 Thomas Munro wrote: > On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin wrote: >> I do like what I see here, the only reason I haven't review is that I can't >> test, since the last modification from hrs@ in the locale generation tools each >> time I try to regenerate the locales it fails. > > During install? I noticed that too but wasn't sure of the correct fix, perhaps: > > diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile > index 76fff6acb17..b6ae2feadac 100644 > --- a/tools/tools/locale/Makefile > +++ b/tools/tools/locale/Makefile > @@ -95,7 +95,7 @@ install: install-${t} > install-${t}: > cd ${LOCALESRCDIR}/${t} && \ > rm -f Makefile *.src && \ > - install -c ${t}/* ${LOCALESRCDIR}/${t} > + install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t} > . endif > .endfor Makes sense. BTW, to test what is in this review, you don't need the install target -- new 'width' target depends only on cldr posix data itself, and modifies etc/final-maps/widths.txt directly.