Date: Sat, 18 Jan 2003 18:10:05 -0800 (PST) From: Giorgos Keramidas <keramida@freebsd.org> To: freebsd-bugs@FreeBSD.org Subject: Re: conf/47147: [PATCH] First look at /usr/local/share/sendmail/cf for sendmail.cf generation. Message-ID: <200301190210.h0J2A565037037@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/47147; it has been noted by GNATS. From: Giorgos Keramidas <keramida@freebsd.org> To: Vadim Ostranitsyn <vadim@alpha.tsu.ru> Cc: bug-followup@freebsd.org Subject: Re: conf/47147: [PATCH] First look at /usr/local/share/sendmail/cf for sendmail.cf generation. Date: Sun, 19 Jan 2003 00:51:36 +0200 (EET) On 2003-01-16 23:24, Vadim Ostranitsyn wrote: > --- Makefile.diff begins here --- > --- Makefile.orig Thu Sep 26 17:39:38 2002 > +++ Makefile Thu Jan 16 22:02:18 2003 > @@ -83,7 +83,9 @@ > # This is the directory where the sendmail configuration files are > # located. > # > -.if exists(/usr/share/sendmail/cf) > +.if exists(/usr/local/share/sendmail/cf) > +SENDMAIL_CF_DIR?= /usr/local/share/sendmail/cf > +.elif exists(/usr/share/sendmail/cf) > SENDMAIL_CF_DIR?= /usr/share/sendmail/cf > .elif exists(/usr/src/contrib/sendmail/cf) > SENDMAIL_CF_DIR?= /usr/src/contrib/sendmail/cf > --- Makefile.diff ends here --- A better check would probably be to look for a file that really *has* to be there, or to avoid the conditional setting of SENDMAIL_CF_DIR with /usr/local subdirs. It is possible that ports are not installed in subdirectories of /usr/local but under /foo. Since it's not possible to know everything about the local setup, the only safe way of using SENDMAIL_CF_DIR in /etc/mail with the Makefile is to use: # cd /etc/mail # make SENDMAIL_CF_DIR=/real/path/to/sendmail/cf The conditional assignments of SENDMAIL_CF_DIR in Makefile will work as expected, and you can use any path you wish for your CF_DIR. To depend on the existence of the /usr/local/share/sendmail/cf directory might even prove to be unsafe and/or break things, on a system that just happens to have an old, empty directory with that name. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301190210.h0J2A565037037>