From owner-svn-src-all@FreeBSD.ORG Wed Nov 2 22:07:19 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EAA3106564A for ; Wed, 2 Nov 2011 22:07:19 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 6EAE68FC1F for ; Wed, 2 Nov 2011 22:07:18 +0000 (UTC) Received: (qmail 63343 invoked from network); 2 Nov 2011 20:44:33 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 2 Nov 2011 20:44:33 -0000 Message-ID: <4EB1BF16.6000408@freebsd.org> Date: Wed, 02 Nov 2011 23:07:18 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Sergey Kandaurov References: <201110161508.p9GF8hIc067651@svn.freebsd.org> <4EB1712C.9000309@citrin.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-all@freebsd.org, Anton Yuzhaninov Subject: Re: svn commit: r226437 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2011 22:07:19 -0000 On 02.11.2011 22:01, Sergey Kandaurov wrote: > On 2 November 2011 21:40, Sergey Kandaurov wrote: >> On 2 November 2011 20:34, Anton Yuzhaninov wrote: >>> On 10/16/11 19:08, Andre Oppermann wrote: >>>> >>>> Author: andre >>>> Date: Sun Oct 16 15:08:43 2011 >>>> New Revision: 226437 >>>> URL: http://svn.freebsd.org/changeset/base/226437 >>>> >>>> Log: >>>> VNET virtualize tcp_sendspace/tcp_recvspace and change the >>>> type to INT. A long is not necessary as the TCP window is >>>> limited to 2**30. A larger initial window isn't useful. >>> >>> In this commit sysctl renamed >>> from net.inet.tcp.sendspace to net.inet.tcp.tcp_sendspace >>> and from net.inet.tcp.recvspace to net.inet.tcp.tcp_recvspace >>> >>> This break POLA without any benefits. >>> Please revert sysctl rename. >> >> That was rather done accidentally as these names also match >> in-kernel variables which hold the corresponding sysctl values. > > Please note, that I restored sysctl names for > tcp_sendspace/tcp_recvspace in svn r227034 revision. Thanks. It was indeed a typo. My bad. Sorry for the confusion. -- Andre