From owner-freebsd-net Tue Jul 30 11:35:22 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0C3637B4C2 for ; Tue, 30 Jul 2002 11:34:58 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79F724432D for ; Tue, 30 Jul 2002 11:31:19 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g6UIUipO008806; Tue, 30 Jul 2002 11:30:44 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g6UIUisN008805; Tue, 30 Jul 2002 11:30:44 -0700 Date: Tue, 30 Jul 2002 11:30:44 -0700 From: Brooks Davis To: Bruce Evans Cc: Brooks Davis , "M. Warner Losh" , net@FreeBSD.ORG Subject: Re: switching to if_xname from if_name and if_unit Message-ID: <20020730113044.A7396@Odin.AC.HMC.Edu> References: <20020730101533.A29988@Odin.AC.HMC.Edu> <20020731041621.H56544-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020731041621.H56544-100000@gamplex.bde.org>; from bde@zeta.org.au on Wed, Jul 31, 2002 at 04:22:23AM +1000 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 31, 2002 at 04:22:23AM +1000, Bruce Evans wrote: > On Tue, 30 Jul 2002, Brooks Davis wrote: >=20 > > On Mon, Jul 29, 2002 at 10:38:34PM -0600, M. Warner Losh wrote: > > > : @@ -280,8 +280,7 @@ ep_attach(sc) > > > : attached =3D (ifp->if_softc !=3D 0); > > > : > > > : ifp->if_softc =3D sc; > > > : - ifp->if_unit =3D sc->unit; > > > : - ifp->if_name =3D "ep"; > > > : + sprintf(ifp->if_xname, "ep%d", sc->unit); > > > > > > strcpy(ifp->if_xname, device_get_name(sc->dev)); > > > > > > might be better, don't you think? >=20 > I think this point has already been covered better by noticing that the > name is already stored in several other places (not just new-bus). I don't think it's stored elsewhere for pure pseudo interfaces like lo or gif though (except as "if_" in the module decleration.) I don't see name that is consistantly associated with all interfaces. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9RttSXY6L6fI4GtQRAkyDAJ9JGduPObE6Mz6WXrMQneL7iCs+agCeLtGU qTo6lhZgJt4VDZZXP0DGkOc= =1Lj8 -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message