From nobody Thu Mar 16 19:39:53 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PcyJq08cWz3yVy8 for ; Thu, 16 Mar 2023 19:39:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PcyJp6Dkkz48tM for ; Thu, 16 Mar 2023 19:39:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678995594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J/1tbQDgEQa/V4Iy484xOoFZX+WfAZ5FMtgMzLmV3jY=; b=a0+0XhSYRk8MEiCmMksml7oPnxM1zh5f2ZxW4E2RWw/XM/tFnaP3W9/cBsnA9owjdU/SZm aiMusZQiBHWXoe24BJd5cqIIZ7F0GRbggarda6pPV+/MSzHVIkW9LRkhOWFFefSUbFZNKy l/8he5UbLjsyjeWHp3mvL471x6A7+mMDSMfKs535xdqSAajpXSK+zCOlyr3jZFlKJ+PUGp 15e9Py1KJt1UHM9CKR+/nFNJrbi59kz3rA8Ic0iLBnTFLKrzz6VEd+TSeG8HsE/ZYJuUd/ 6fdCSjys3Xcii7xKsM0ZMTLYG5jyJDmLZnH+kXVkRMxPDD6fVAG70k7ycvzcdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678995594; a=rsa-sha256; cv=none; b=aTXDg9sXVxVJN4GZgIX6WX9JMjL1711dDwzKmW08pKiGgJ7ztsqO7mvarRXDbBg7xYMaxf Mi5RbroEt8ciX5uQa87E9OK9/Xp9Xndxm1TLx8TFmO3mWBzcN1QvVt47U2VlB8iK0gwJ5p k+rVjdqnmDJOqbYabUI4eArT9s2bRmJtoFHDoQQDlLWXmx0/G4GO7jHK/r0Z/rzJdUal6D 2sCROBgBsQGmDpbk+PdLG+RSVTOHyj1GXoY8Afjgpz10tdStzA0sNurRz2gkI/ipEQZlVk mroopf4JGN5nPmBFHw2vk10hTvK05JZQ1dH7GED1H5bWlH9I2ynsnVhUW4oklg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PcyJp5K7Rzw3K for ; Thu, 16 Mar 2023 19:39:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32GJds1S036641 for ; Thu, 16 Mar 2023 19:39:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32GJdskS036640 for net@FreeBSD.org; Thu, 16 Mar 2023 19:39:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268490] [igb] [lagg] [vlan]: Intel i210 performance severely degraded Date: Thu, 16 Mar 2023 19:39:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.4-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kbowling@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268490 --- Comment #31 from Kevin Bowling --- (In reply to Daniel Duerr from comment #30) The idea is to bisect in somewhat of a reverse fashion where you introduce = the one line change on during each bisection step: - em_if_set_promisc(ctx, if_getflags(ifp)); + em_if_set_promisc(ctx, IFF_PROMISC); and see if that triggers a different resultant commit hash. Instead of wal= king backwards to see where things break, which you did, and which identified th= is line of code, we want to see when this line change results in bad performan= ce if it were applied earlier before, and during other code changes. If I understand correctly, applying this one line change to 12.2 did not result = in poor performance. If you have already done this and the performance is poo= r on 12.2 with the change there is no need to bisect further. The drivers are very similar between 12, 13, and 14 so if it is a driver regression it probably affects all of these. If it is some cross cut with = the network stack there could be something different but I am not aware of major differences in this area. --=20 You are receiving this mail because: You are the assignee for the bug.=