From owner-svn-src-head@FreeBSD.ORG Wed Mar 10 17:46:51 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DA701065677; Wed, 10 Mar 2010 17:46:51 +0000 (UTC) (envelope-from tomelite82@gmail.com) Received: from mail-qy0-f183.google.com (mail-qy0-f183.google.com [209.85.221.183]) by mx1.freebsd.org (Postfix) with ESMTP id E70CF8FC23; Wed, 10 Mar 2010 17:46:50 +0000 (UTC) Received: by qyk14 with SMTP id 14so3720254qyk.9 for ; Wed, 10 Mar 2010 09:46:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=mDvf9MUuPyww+DMS4L5ql5721SlY6uHqjYkFDLYQnfQ=; b=ab0jdvLlJ5FtSZCldC7zGZo+FFZwY8YNWPJTy/P8hbc32VuBa1SkdFSu3ohQX3FAD+ 4G7MhUgVtydc3kGxud42k2vULeji64fB+SykS9/iU6BewzC0TsqVf04UkZD/zXLRZZC9 1lgFeo/VF78CJm+5m+c7EFWT4+Fl76Hn77+jE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=VYyDQJnsLAE/3BxOUrwgLwVZGNXIjCm3W/XIr+k9ai1IC4MgvufoAzEz8is9QL8E74 S2Z8yqOk61x2F3mRz2kq+DxEvNgP9Wz7iIAmHGRocrK2mEl/UTiquWKUE1WdUpvhsxdQ XC5VureOscqcZWqibhWi9vxT0Yi2GJooIFLuA= MIME-Version: 1.0 Sender: tomelite82@gmail.com Received: by 10.220.128.30 with SMTP id i30mr142265vcs.238.1268243209455; Wed, 10 Mar 2010 09:46:49 -0800 (PST) In-Reply-To: <20100310160858.GC58634@dragon.NUXI.org> References: <201003090111.o291Bj79062503@svn.freebsd.org> <20100310152339.GA57873@dragon.NUXI.org> <201003101050.46696.jhb@freebsd.org> <20100310160858.GC58634@dragon.NUXI.org> Date: Wed, 10 Mar 2010 09:46:49 -0800 X-Google-Sender-Auth: e8ea8a20c7dc5667 Message-ID: <9ace436c1003100946s2e8f5f1cx1adee809c25ea92d@mail.gmail.com> From: Qing Li To: obrien@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r204902 - in head/sys: net netinet X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2010 17:46:51 -0000 > > I looked at it, and at the diff of his original commit. =A0The changes we= re > large enough that I don't want to assume his patch takes care of all the > issues given that patch hasn't been committed verbatim. > The change itself is not a huge change but if you disagree, then please be specific. The current mechanism and code is broken according to the original design intention. I have a habit of not committing things or quick finger until everyone had a chance to test the patch, although I have done unit testings myself. When you say "... made the kernel toxic" and "...I don't want to assume ...", well, agai= n, be specific instead about what you mean and give me details. The other reason I decided to postpone is because I wanted to spend more time with the PPP driver. Every other PPP interface types (if_tun, if_ng etc.) updates the if_link_state variable except PPP. > > We also have reports of the patch not working in freebsd-current@. > I have seen that report but it lacks detail. I have asked for more information and will investigate further as soon as it becomes available. -- Qing