From nobody Fri Mar 1 20:43:29 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tmg6F1xPBz5D2DV; Fri, 1 Mar 2024 20:43:33 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tmg6F1M5dz4tRR; Fri, 1 Mar 2024 20:43:33 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709325813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHcwuBUFwvx4A9xakUlcoWfeGIQPGc0CAyIn2pFZIso=; b=GWdFj1h2fdT5HAhRKlAsAX9VqoBpJErjqXXFSQ5JllDB82K7WVCCUfssKGeN9sL44unfm7 jcMLX8dHimoeDdXzEHt2rlgjuTLzcXKuMniiX86vP7JH6xz6tltADo8Gr1nKw+wS4+Mntj 3pjJFYYsKuCPhBE9lgw15CU4hGh/Swff3UYx3kvvqCoUTVQC1iG80l9ICd00D+CVsDIV6F Ea3gvf2cYIZmoc9lYrORGHtN6yE5T50B7QKgBP9UoTDxMrXSOIS/+M6tLbICDWrvKV+mF1 B/qkx75BJRK7Xh5ReZTJdT83eANo2aHb0h+4pEr7TXYo/HnAZaOJEJqC5BzHWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709325813; a=rsa-sha256; cv=none; b=iTMw69A+UKoAf53IvP1p83BHhOOWlO/3GHawUSpBLizvMTzvs1WwB+syN3uE/ZSxWUm2q0 ea/wTY+juToo/Z3dBHdjYgTfrZs8KMv8S3YPpiBzwyRHkwcuVAgFVVyja7hFlFGpQCuDTX ofrr1HKBlLj27bzWrS4FNg7W/TFKPu9md8PaRQ/M2h1e7RerGcLiyiOb2VvSzo//v+Jsuj Jy6qptc7aVgHSfjdtlS890qAO7dC7jCu4cljE7jHxAXvbHZxE/dHDT64e6nbtTBA0Lq7/t a2ikwZfAOnfIdnGPALybsFjWgpn4zvc3D3htNxMKwxzquOy7zneQy9jcEAMY3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709325813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHcwuBUFwvx4A9xakUlcoWfeGIQPGc0CAyIn2pFZIso=; b=vA46INIAPgLCSt4Vl49TOMbQFRH8tZkyaSOf3cJyF5yunF9hW4QodeOSad0sPFxhkEnW9Y kIBBdOC44qFhE6ZaGljm23cWpBWFjA+vvEMOYJ15YKgimU/HsS0tcF3iNgFMkLpVeQvkh/ qwFC7lO+pDLh8qE8JxPSm6aeg1FiQWcfBnkT0P7oIg43mLTDgZZ0nqVtgmlCqVI89kqgYg DAaYYRKGHfeynTFNdhm3N6JuJBLiX4Wmvq+JEBN1t+zaV6aPuGJ2z+XF0iHDSH4dh3BqG5 ADrsYKkMKqTfS3a8uD9GqZDsXkQfehgk7BHwy89WOzUlvFwHRlWVTMPSGsdcjg== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Tmg6F0H4bz1HDP; Fri, 1 Mar 2024 20:43:33 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id AD8951AF1C4; Fri, 1 Mar 2024 21:43:29 +0100 (CET) Date: Fri, 1 Mar 2024 21:43:29 +0100 From: Baptiste Daroussin To: Daniel Engberg Cc: Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob. Message-ID: References: <202403011927.421JRqxx065749@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 01, 2024 at 09:20:51PM +0100, Daniel Engberg wrote: > On 2024-03-01T20:27:52.000+01:00, Gleb Popov > wrote: > > > The branch main has been updated by arrowd: > >  > > URL: https://cgit.FreeBSD.org/ports/commit/?id=c2afef5c2587738b16b52def34edcebe4e421905 > >  > > commit c2afef5c2587738b16b52def34edcebe4e421905 > >  > > Author:     Gleb Popov  > >  > > AuthorDate: 2024-03-01 19:25:37 +0000 > >  > > Commit:     Gleb Popov  > >  > > CommitDate: 2024-03-01 19:26:53 +0000 > >  > >     Features/testing.mk [http://testing.mk]: Introduce the TESTING_UNSAFE knob. > >  > >      > >  > >     Approved by:    tcberner > >  > > --- > >  > >  Mk/Features/testing.mk [http://testing.mk] | 5 ++++- > >  > >  1 file changed, 4 insertions(+), 1 deletion(-) > >  > > diff --git a/Mk/Features/testing.mk [http://testing.mk] b/Mk/Features/testing.mk [http://testing.mk] > >  > > index 15af7e28eb7c..a266f6effe91 100644 > >  > > --- a/Mk/Features/testing.mk [http://testing.mk] > >  > > +++ b/Mk/Features/testing.mk [http://testing.mk] > >  > > @@ -4,12 +4,15 @@ > >  > >  # - If set, and the port supports it, the software's test suite will be compiled > >  > >  #   and run during the normal building pipeline between 'stage' and 'package' > >  > >  #   stages. > >  > > +# - A port may define TESTING_UNSAFE=yes if its tests are known to fail at the > >  > > +#   moment. > >  > >   > >  > >  .if !defined(_TESTING_MK_INCLUDED) > >  > >  _TESTING_MK_INCLUDED=    yes > >  > >  TESTING_Include_MAINTAINER=    portmgr@FreeBSD.org > >  > >   > >  > > +.  if !defined(TESTING_UNSAFE) > >  > >  _TESTING_PACKAGE_DEP=    test > >  > > +.  endif > >  > >   > >  > >  .endif > >  > > - > > Hi, > > Thanks for adding this, however this won't work on ports that uses > TEST menu option as far as I can tell which is a relatively common > occurence? > > Se also > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495 > > Best regards, > > Daniel > > In my opinion it should disappear in favor of the feature which clearly makes more sense. Best regards, Bapt