Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Feb 2001 01:24:16 +0200 (EET)
From:      Maxim Sobolev <sobomax@freebsd.org>
To:        reg@freebsd.org
Cc:        ports@freebsd.org
Subject:   Libtool port and libltdl library [patch for review]
Message-ID:  <200101312324.f0VNOGm78023@vic.sabbo.net>

next in thread | raw e-mail | index | archive | help

--%--multipart-mixed-boundary-1.77961.980983456--%
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi,

I noted that at least several ports make use of libltdl library, which is
buindled with libtool package. Hovewer, for unknown for me reasons, FreeBSD
libtool port doesn't build/install this small library, which results
in code duplication (situation is similar to that with libintl - in the
absence of libltdl ports build their own version usually buindled with each
particular package). Attached patch should solve this problem by installing
the library along with corresponding include file with libtool port. Please
review and if possible approve attached patch.

Thank you.

-Maxim

--%--multipart-mixed-boundary-1.77961.980983456--%
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Description: ASCII text
Content-Disposition: attachment; filename="libtool.patch"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/libtool/Makefile,v
retrieving revision 1.13
diff -d -u -r1.13 Makefile
--- Makefile	2000/10/24 16:00:52	1.13
+++ Makefile	2001/01/31 11:55:27
@@ -7,7 +7,7 @@
 
 PORTNAME=	libtool
 PORTVERSION=	1.3.4
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	libtool
@@ -18,8 +18,8 @@
 # FreeBSD support, and would require that all Ports users upgrade for no
 # reason.
 
+INSTALLS_SHLIB=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--disable-ltdl-install
 CONFIGURE_ENV=	PREFIX=${PREFIX}
 
 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/devel/libtool/pkg-plist,v
retrieving revision 1.4
diff -d -u -r1.4 pkg-plist
--- pkg-plist	2000/06/03 00:48:29	1.4
+++ pkg-plist	2001/01/31 11:55:27
@@ -1,8 +1,12 @@
 bin/libtool
 bin/libtoolize
+include/ltdl.h
 @unexec install-info --delete %D/info/libtool.info %D/info/dir
 info/libtool.info
 @exec install-info %D/info/libtool.info %D/info/dir
+lib/libltdl.a
+lib/libltdl.so
+lib/libltdl.so.1
 share/aclocal/libtool.m4
 share/libtool/config.guess
 share/libtool/config.sub
Index: files/patch-libltdl_configure
===================================================================
RCS file: patch-libltdl_configure
diff -N patch-libltdl_configure
--- /dev/null	Wed Jan 31 03:55:27 2001
+++ patch-libltdl_configure	Wed Jan 31 03:55:27 2001
@@ -0,0 +1,14 @@
+
+$FreeBSD$
+
+--- libltdl/configure	2001/01/31 10:58:38	1.1
++++ libltdl/configure	2001/01/31 10:59:14
+@@ -1455,7 +1455,7 @@
+ esac
+ 
+ # Check for any special flags to pass to ltconfig.
+-libtool_flags="--cache-file=$cache_file"
++libtool_flags="--cache-file=$cache_file --disable-ltlibs"
+ test "$enable_shared" = no && libtool_flags="$libtool_flags --disable-shared"
+ test "$enable_static" = no && libtool_flags="$libtool_flags --disable-static"
+ test "$enable_fast_install" = no && libtool_flags="$libtool_flags --disable-fast-install"

--%--multipart-mixed-boundary-1.77961.980983456--%--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101312324.f0VNOGm78023>