From owner-svn-src-all@freebsd.org Tue Jan 29 16:55:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7BE114C39D7; Tue, 29 Jan 2019 16:55:22 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 578FF8F229; Tue, 29 Jan 2019 16:55:22 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x443.google.com with SMTP id 64so9917794pfr.9; Tue, 29 Jan 2019 08:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UHkzr4i7STaDwuO5O8TIk9jO67MasdBHe0j9XjyZelI=; b=JOUFlKSj7ocobwvddmVlUvokjPj7BJfjHgMgOak23EVvYFljPTD+kQJMpacL7xSAlM 10qNFW7UlYrETSvrBn5xnJz3ogvcMZaecq/ZzsH4yfZZZMVbEpSPy0PMPXpJJvCpzu9T Qn9iQ6IjRb+n/x+rFTWwYsQFUihdoLvHh68Cs27B3Jr4HARzFpYl14l/FY9ZcYPeEWY3 +0+gjOOEikrbb6s4BNzd26DDPcTD8vnYwoB74eqFD0ct/fMnL4JZ++bE+P3QfHcfxdhG BQtfetUeQ8cRawqEm+Fk93vZDb4W/D37XbVqUTbM25/DyYPicdTsdTE5+YgOKke/8d2d qUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UHkzr4i7STaDwuO5O8TIk9jO67MasdBHe0j9XjyZelI=; b=r9lMtxr8bNYzRXK/YNw1aTgRRRUOF/+fU6gooQZrjff4xrDsb03bhcpoI748LFweTB r6b340uRs3SkfVJ7dUZsE/Kmum0z3Pw7ROxDRtcrVAmTb9rHex+q310tdeYqM6KRVoQl Z+ZLj+MlAd345ZM6zwKgUE62IKJcJPEajJYQ/t0Je/JvRUwKZ/P1JPiZPI7jVaWy9ORy 0e0Y3vbHQ0AF2Hk+XwAw39RSyETLy//0FVXFM8qQcdN1SJwbWz3gJSpzcj0ezteXnzsC ZN/kM7xD+nm5zGRg/+DA714DZttnEWlorXsm+tqaasSiqA5Fphu3Jldd6i+GmP5t/Rrv GXSQ== X-Gm-Message-State: AJcUukcJ1KF28SddnzyR2hWKBXxKvSE/xsc4FRYHuI+kv/b2EWV8W01T Xv0CbRrBhKT96mWHt5ON/TWq46e6 X-Google-Smtp-Source: ALg8bN5wiOJqF2zQWmX2oRaZI/B0hYLrEW7wtONyQE8ex3epUoJH1xkXfWmr7B02fOjjilgZFZZg+Q== X-Received: by 2002:a63:374e:: with SMTP id g14mr24878591pgn.59.1548780920941; Tue, 29 Jan 2019 08:55:20 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id b2sm65024669pfm.3.2019.01.29.08.55.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 08:55:20 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r343543 - head/sbin/bectl/tests From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: Date: Tue, 29 Jan 2019 08:55:19 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5687EE07-74FB-4233-B51D-C8948641E8CB@gmail.com> References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> To: Kyle Evans X-Rspamd-Queue-Id: 578FF8F229 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.973,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 16:55:23 -0000 > On Jan 29, 2019, at 08:39, Kyle Evans wrote: >=20 >> On Tue, Jan 29, 2019 at 10:32 AM Enji Cooper wrot= e: >>=20 >>=20 >>>> On Jan 28, 2019, at 20:10, Kyle Evans wrote: >>>>=20 >>>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrote:= >>>>=20 >>>> Author: kevans >>>> Date: Tue Jan 29 04:08:49 2019 >>>> New Revision: 343543 >>>> URL: https://svnweb.freebsd.org/changeset/base/343543 >>>>=20 >>>> Log: >>>> bectl(8) test: Force destroy the zpool in cleanup >>>>=20 >>>> This is a wild guess as to why bectl tests failed once upon a time in C= I, >>>> given no apparent way to see a transcript of cleanup routines with Kyua= . The >>>> bectl tests construct a new, clean zpool for every test. The failure >>>> indicated was because of a mount that was leftover from a previous test= , but >>>> the previous test had succeeded so it's not clear how the mount remaine= d >>>> leftover unless the `zpool get health ${pool}` had somehow failed. >>>>=20 >>>=20 >>> I left out: the tests are supposed to be constructed to clean up any >>> mounts that were left over in the course of the test, hence the >>> assumption that the failure lies in the cleanup. >>=20 >> Hi Kyle, >>=20 >> The tests use a deterministic zpool name defined locally (not globally), a= nd will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succeed= s. >>=20 >> The tests will work the first time (when the zpool doesn=E2=80=99t exist)= , but I believe they=E2=80=99re actually introducing nondeterminism by accid= ent. I will propose a fix for this. >>=20 >> There=E2=80=99s a way to decipher why things failed from /var/log/message= s and kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t k= now what to look for. Can you please provide a failing ci run? >>=20 >=20 > Hi, >=20 > Thanks! Any help is appreciated -- my inquiry to -testing@ in response > to the weekly report where the failing test [1] was mentioned has been > met with silence. The failure is consistent in the i386-test job, but > amd64-test sees nothing of the sort (and neither does my local > testing). Thanks for the reminder to rejoin that list. > [1] https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/426/testReport/= sbin.bectl/bectl_test/bectl_mount/ It=E2=80=99s pretty obvious from the above run what=E2=80=99s going on from t= he output. A similarly named zpool (same prefix; suffixed with a 2) is being= matched by grep, even though the test sets up one with a suffix in the prec= eding steps. It=E2=80=99s probably and issue with timing and the bhyve implementation for= amd64 vs i386, or something else. Cheers, -Enji=