From owner-cvs-all  Wed Mar 28  4:40:47 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0744B37B71E; Wed, 28 Mar 2001 04:40:39 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA06465;
	Wed, 28 Mar 2001 22:40:33 +1000
Date: Wed, 28 Mar 2001 22:39:54 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: "Justin T. Gibbs" <gibbs@scsiguy.com>
Cc: Paul Saab <ps@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/ata ata-disk.c
 src/sys/dev/ida ida_disk.c src/sys/dev/twe twe_freebsd.c 
In-Reply-To: <200103271501.f2RF1cs69363@aslan.scsiguy.com>
Message-ID: <Pine.BSF.4.21.0103282231430.25660-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, 27 Mar 2001, Justin T. Gibbs wrote:

> >ps          2001/03/26 22:24:08 PST
> >
> >  Modified files:
> >    sys/cam/scsi         scsi_da.c 
> >    sys/dev/ata          ata-disk.c 
> >    sys/dev/ida          ida_disk.c 
> >    sys/dev/twe          twe_freebsd.c 
> >  Log:
> >  Change the dump routines to only abort if control-c is pressed.
> >  If any other key is pressed, print a message stating that control-c
> >  is how to abort.

Ugh.  I like holding down the space bar to abort all stages of the
reboot as fast as possible.

> Why not replace the call to cncheckc with a more generic "dump status"
> callback that prints stats, checks for abort, etc.  The number of block
> devices we support that either currently support crash dumps or should
> is growing, and duplicating all of the watch dog code, etc in each one
> seems silly.

Most of the dump routines should be centralized.  The driver-specific
parts should be just an initialization routine and a strategy routine.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message