From owner-freebsd-smp  Tue May  7 07:21:47 1996
Return-Path: owner-smp
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id HAA09758
          for smp-outgoing; Tue, 7 May 1996 07:21:47 -0700 (PDT)
Received: from tfs.com (tfs.com [140.145.250.1])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id HAA09752
          for <smp@freebsd.org>; Tue, 7 May 1996 07:21:45 -0700 (PDT)
Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP
	id m0uGne2-0003wbC; Tue, 7 May 96 07:21 PDT
Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.7.5/8.6.12) with SMTP id OAA12725 for <smp@freebsd.org>; Tue, 7 May 1996 14:21:44 GMT
X-Authentication-Warning: critter.tfs.com: Host localhost [127.0.0.1] didn't use HELO protocol
To: smp@freebsd.org
Subject: comments
Date: Tue, 07 May 1996 14:21:44 +0000
Message-ID: <12723.831478904@critter.tfs.com>
From: Poul-Henning Kamp <phk@critter.tfs.com>
Sender: owner-smp@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


I spent a couple of minutes with the current code and noticed
only a few things:

1. the PG_N bit should be set on the apic page.

2. apic_startup is never called.

3. expect_mplock should check smp_active I think.

4. the apic isn't mapped I think...

Poul-Henning