From nobody Tue Jun 17 14:17:09 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bM8891ZvNz5yNkv; Tue, 17 Jun 2025 14:17:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bM8880s1pz3D5j; Tue, 17 Jun 2025 14:17:12 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of cy.schubert@cschubert.com designates 3.97.99.32 as permitted sender) smtp.mailfrom=cy.schubert@cschubert.com; dmarc=permerror reason="p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com" header.from=cschubert.com (policy=permerror) Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id RRwGuoi839JM2RX7fukeCO; Tue, 17 Jun 2025 14:17:11 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id RX7du9n3UWbOaRX7euQMpq; Tue, 17 Jun 2025 14:17:11 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=Q5lx4J2a c=1 sm=1 tr=0 ts=685178e7 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=NN3ADSXLk06O8BHnmAkA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 4D6CF66A; Tue, 17 Jun 2025 07:17:09 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 194C31F0; Tue, 17 Jun 2025 07:17:09 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert , Ronald Klop , Cy Schubert , dev-commits-src-main@freebsd.org, dev-commits-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: git: b6e33f0cd536 - main - rc.d/mountcritlocal: Make sure zpools are imported for legacy ZFS In-reply-to: References: <240137891.21754.1749997280448@localhost> <20250616023154.3D2B730C@slippy.cwsent.com> Comments: In-reply-to Lexi Winter message dated "Tue, 17 Jun 2025 12:55:14 +0100." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 17 Jun 2025 07:17:09 -0700 Message-Id: <20250617141709.194C31F0@slippy.cwsent.com> X-CMAE-Envelope: MS4xfCcB6uQPwZLBZdAh0eRDeo83LkxsJ6EBfjOD6PzTgsgZif/C+ZZxlAc8KVDz7Y90VY+q9bzlLKw8FoCho8io+qJnZsOd225ll9F1F5/ghv8KEyv80BHU 3oFdhzHE1oMMUATELr7n+4g9B3A9T8bEJwkQr7HE/s0jYH1X4G5e8xR5KGnBrol66e/H9Vb3DkiZijS1QHKeTQrA979ufu6xPDJe73ZLuDEGuqYV2lJpGkyr xWvJBNgj88mO36IGc4T0QnbV5E0LCJ3bJLskvMHbkecYjlRq+Fuktl/Gqr9inz/8hdC+jtPlrYcrUPjwoIbP+VL4CbupILF+AIH3ZuuwRh0Pi2leg+qK3zAF gbLixQVC X-Spamd-Result: default: False [-1.18 / 15.00]; NEURAL_HAM_LONG(-0.99)[-0.995]; NEURAL_HAM_SHORT(-0.89)[-0.892]; NEURAL_SPAM_MEDIUM(0.61)[0.610]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:3.97.99.32/31]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[3.97.99.32:from]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; REPLYTO_EQ_FROM(0.00)[]; R_DKIM_NA(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_BAD_POLICY(0.00)[cschubert.com : p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org,dev-commits-src-all@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6] X-Rspamd-Queue-Id: 4bM8880s1pz3D5j X-Spamd-Bar: - In message , Lexi Winter writes: > Cy Schubert: > > In message <240137891.21754.1749997280448@localhost>, Ronald Klop writes: > [...] > > > > + if [ "$vfstype" =3D "zfs" -a "$a" !=3D "#" ]; then > > > > > > Does this mean that a comment # must always be folllowed by a whitespac= > e? > > > Yes. It's a hack but it's the only way without grep (when /usr may not be= > =20 > > mounted). In the very worst case rc.d/zpool will be needlessly executed. > > could you not check for a comment using the # variable expansion operator? > i.e. if [ "${a#\#}" !=3D "$a" ] then the variable starts with a # character: > > $ echo $line1 > #Foo bar > $ echo $line2 > Foo bar > $ echo $line3 > Foo # bar > $ [ "${line1#\#}" =3D "$line1" ] || echo comment > comment > $ [ "${line2#\#}" =3D "$line2" ] || echo comment > $ [ "${line3#\#}" =3D "$line3" ] || echo comment > $ Looks like this works! I learn something new every day. Thank you. I will do a couple of reboots with it before committing your recommended fix. Thanks. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0