From owner-svn-src-head@FreeBSD.ORG Tue Oct 22 19:01:17 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 29588AF5; Tue, 22 Oct 2013 19:01:17 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-x22a.google.com (mail-ee0-x22a.google.com [IPv6:2a00:1450:4013:c00::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 47F842FE1; Tue, 22 Oct 2013 19:01:16 +0000 (UTC) Received: by mail-ee0-f42.google.com with SMTP id b45so4706824eek.15 for ; Tue, 22 Oct 2013 12:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=AefCGAm1VV3xz/zGPmrue3o/N5lXnuc98op6klhhiPU=; b=d7lg3YB1t+h3vsvuzi29yhCxugH5fNpwYsz7xS42qMvrnDbIwo5+Y5qz/l5SmG3FRh Bf8lMPUGHFKbMI43p9NZudZ3iqU7UxbCEXvoLkupt9PJDat3vvmSN6D4oGuE+m8as8Ak K9kmOaeBlaYbL7WDZBaPNXcOLEo8zXqV3QAjcvkfAk6DQRNm58O9r/ASh2QoqT3COkQg gw+DN6EhSHKPiWWr19ss2mXi1Id0cbFX1rE2w+5832VyQNDKdKgGjBheab8OYRr0JCSl g7365urUMdpxkNIDP+qvtX36SqfYrDb84NvhLEVLcNRLQ50BUQvbUI0pxG/IZe75ncDx g+Cg== X-Received: by 10.15.24.68 with SMTP id i44mr1606034eeu.87.1382468474649; Tue, 22 Oct 2013 12:01:14 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([178.137.150.35]) by mx.google.com with ESMTPSA id w6sm49593124eeo.12.2013.10.22.12.01.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Oct 2013 12:01:13 -0700 (PDT) Sender: Alexander Motin Message-ID: <5266CB77.7080001@FreeBSD.org> Date: Tue, 22 Oct 2013 22:01:11 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130616 Thunderbird/17.0.6 MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r256884 - in head: share/man/man9 sys/geom References: <201310221021.r9MALLhP097274@svn.freebsd.org> <201310221447.35676.jhb@freebsd.org> In-Reply-To: <201310221447.35676.jhb@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 19:01:17 -0000 On 22.10.2013 21:47, John Baldwin wrote: > On Tuesday, October 22, 2013 6:21:21 am Alexander Motin wrote: >> Author: mav >> Date: Tue Oct 22 10:21:20 2013 >> New Revision: 256884 >> URL: http://svnweb.freebsd.org/changeset/base/256884 >> >> Log: >> Remove Giant-locked drivers support (DISKFLAG_NEEDSGIANT flag) from disk(9). >> >> Since at least FreeBSD 7 we had only four of them in the base tree, and >> in head branch, thanks to jhb@, we have no any for more then a year. > > I had this additional change in my local branch, what do you think of it? We > should probably keep it unless we bump DISK_VERSION and drop support for older > disk structures. I think we could probably merge it to 10 along with your > change as well: It looks good to me, while I don't know how much useful can it be. I am not sure how many old binary drivers are there and how many of them survive switch from earlier FreeBSD versions to 10.x. But since it cost almost nothing I have no objections. > --- //depot/vendor/freebsd/src/sys/geom/geom_disk.c > +++ //depot/user/jhb/cleanup/sys/geom/geom_disk.c > @@ -654,6 +654,13 @@ > dp->d_name, dp->d_unit); > return; > } > + if (dp->d_flags & DISKFLAG_RESERVED) { > + printf("WARNING: Attempt to add non-MPSAFE disk %s%d\n", > + dp->d_name, dp->d_unit); > + printf("WARNING: Ignoring disk %s%d\n", > + dp->d_name, dp->d_unit); > + return; > + } > KASSERT(dp->d_strategy != NULL, ("disk_create need d_strategy")); > KASSERT(dp->d_name != NULL, ("disk_create need d_name")); > KASSERT(*dp->d_name != 0, ("disk_create need d_name")); > --- //depot/vendor/freebsd/src/sys/geom/geom_disk.h > +++ //depot/user/jhb/cleanup/sys/geom/geom_disk.h > @@ -102,6 +102,7 @@ > void *d_drv1; > }; > > +#define DISKFLAG_RESERVED 0x1 /* Was NEEDSGIANT */ > #define DISKFLAG_OPEN 0x2 > #define DISKFLAG_CANDELETE 0x4 > #define DISKFLAG_CANFLUSHCACHE 0x8 > -- Alexander Motin