From owner-freebsd-ports Sat Mar 22 3:48:13 2003 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFDE037B404; Sat, 22 Mar 2003 03:48:11 -0800 (PST) Received: from shrike.submonkey.net (pc1-cdif2-5-cust38.cdif.cable.ntl.com [81.101.150.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56D5643FA3; Sat, 22 Mar 2003 03:48:09 -0800 (PST) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.12) id 18whTs-000KXZ-00; Sat, 22 Mar 2003 11:48:08 +0000 Date: Sat, 22 Mar 2003 11:48:08 +0000 From: Ceri Davies To: Yar Tikhiy Cc: ports@freebsd.org Subject: Re: WRKSRC Message-ID: <20030322114808.GA6323@submonkey.net> Mail-Followup-To: Ceri Davies , Yar Tikhiy , ports@freebsd.org References: <20030322114224.GA19927@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030322114224.GA19927@comp.chem.msu.su> User-Agent: Mutt/1.5.3i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sat, Mar 22, 2003 at 02:42:24PM +0300, Yar Tikhiy wrote: > Hello, > > The FreeBSD Porter's Handbook, subsection 4.8.1, reads: > > The variable lists the name of the directory that is created > when the application's distfiles are extracted. If our > previous example extracted into a directory called foo (and > not foo-1.0) you would write: > > WRKSRC= foo > > That is while in reality one has to write: > > WRKSRC= ${WRKDIR}/foo > > since WRKSRC is treated by bsd.port.mk as a full pathname. > > So which one, the handbook or bsd.port.mk, is to be changed? Is > there any reason to have this "${WRKDIR}/" stuff in each Makefile > utilizing WRKSRC? A quick grep seems to indicate that it would be easier to change the handbook, but that's not necessarily the correct solution ;) I've got PR misc/50137 assigned to me with a patch for the handbook; I'll wait over the weekend to see what the consensus turns out to be. Ceri -- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message