From owner-freebsd-emulation@FreeBSD.ORG Fri Nov 20 09:35:46 2009 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BAB21065670 for ; Fri, 20 Nov 2009 09:35:46 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 21C2C8FC17 for ; Fri, 20 Nov 2009 09:35:45 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2F1FA.dip.t-dialin.net [217.226.241.250]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 6DD1E844044; Fri, 20 Nov 2009 10:35:40 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id CDFC110D3B6; Fri, 20 Nov 2009 10:35:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1258709737; bh=08veExs+sMZ62u/ydKo2I80gZDTGcpY5ZFH810wKEf0=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=RqvqNsIpYxaz4DKqDmz4Uqs2IpP3bkXsmCuheVcA9Hgujua2ZiYFkNumPRSLCYTS1 D/JovzCINo51+LQKJOIOYSAkz1SpuXFAaF41aUHp0aCV/93a5lc9cbxjvnF6lM7kDc xHnXiBHk34Vsdyng1K4v8UEbDAAsuKat2rrOiuV5nAFTua6iuIZ78cmbeZKXXBk61Z OlykTVXCN0bkEf33QmjW7UZFZl4QAUV3z/O3qiwO8HyEYK2IrpTREElKSTa6ZRvkgm Zz+9COONqoO66pakeZbzSxLM/p4VmaL6vLgdBU7htIfast8Ag50rVOxkWimZ/I1czZ MtASropfNAu+w== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id nAK9ZaXj057042; Fri, 20 Nov 2009 10:35:36 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 20 Nov 2009 10:35:35 +0100 Message-ID: <20091120103535.815072bwgvis0io0@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Fri, 20 Nov 2009 10:35:35 +0100 From: Alexander Leidinger To: "J.R. Oldroyd" References: <20091119153159.610debc2@shibato.opal.com> In-Reply-To: <20091119153159.610debc2@shibato.opal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.3.5) / FreeBSD-8.0 X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 6DD1E844044.69498 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1259314541.36855@vL23B9WPpRp0dnb/5nBTkg X-EBL-Spam-Status: No Cc: freebsd-emulation@freebsd.org Subject: Re: Emulation of Linux V4L ioctls X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2009 09:35:46 -0000 Quoting "J.R. Oldroyd" (from Thu, 19 Nov 2009 15:31:59 -0500): > I have added support for emulation of the Linux V4L video ioctls > in compat/linux/linux_ioctl.[ch]. Wow, great! > I am not a committer; the work can be found here: > http://opal.com/freebsd/sys/compat/linux/ > These diffs are made to the 8.0-rc3 sources. Some things I noticed and worry about: - videodev.h does not have a license, did you generate it yourself or did you take it from somewhere? - Does it needs to be named videodev.h, or can it also be linux_videodev.h? (if we may want to install this header at some point in time, it should have a name compatible with linux, else we should maybe add a linux_ prefix for consistence and for making it very obvious what we are talking about) - Why are you using __s32 and so on instead of the normal fixed size int types? We also have lint for "linux int" and so on in other files. - On which architecture has this been tested? - Will it run in linux32 emulation on amd64? - Are those structures known in userland (and as such need to have a specific size)? If yes, do they have different sizes in linux depending if the kernel is a 64bit kernel (amd64) or 32bit kernel (x86)? - Has this been run through a "make universe"? Bye, Alexander. -- WARNING TO ALL PERSONNEL: Firings will continue until morale improves. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137