Date: Wed, 14 Mar 2012 23:36:48 -0500 From: Doug Barton <dougb@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/resin3 Makefile distinfo pkg-plist ports/www/resin3/files install.sh patch-apache1-Makefile.in patch-apache2-Makefile.in patch-configure patch-resin.conf pkg-deinstall pkg-install pkg-message-advanced.in pkg-message.in ... Message-ID: <4F6171E0.4010506@FreeBSD.org> In-Reply-To: <201203131629.q2DGTN9a082326@repoman.freebsd.org> References: <201203131629.q2DGTN9a082326@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At minimum this violates the rule about not adding new rc.d scripts with the .sh suffix. Please carefully read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, especially the pre-commit checklist. (Hint, there are other problems with these scripts. I suggest you read that web page and submit a patch to -rc@ or -ports@) It's also not clear to me what the %%APP_NAME%% stuff in resin3 is for, but I haven't looked at it deeply yet. On 3/13/2012 11:29 AM, Jason Helfman wrote: > jgh 2012-03-13 16:29:23 UTC > > FreeBSD ports repository > > Modified files: > www/resin3 Makefile distinfo pkg-plist > www/resin3/files patch-apache2-Makefile.in patch-configure > pkg-message.in > Added files: > www/resin3/files resin3.sh.in resin3ctl.in > Removed files: > www/resin3/files install.sh patch-apache1-Makefile.in > patch-resin.conf pkg-deinstall > pkg-install pkg-message-advanced.in > resin.sh.in resinctl > Log: > - Update to 3.1.11 [1] > - while here [2] > - remove apache13 support, and move apache22 to options framework > - Use default user of www > - Remove pkg-install and pkg-deinstall files (not necessary now) > - Remove advanced packaging message and put text into standard package message > - Remove apache packaging message and put into standard package message > - Use SUB_FILES and remove REPLACE_FILES > - Use rc subroutine method > - Remove COPYDIRS of libexec64 (no longer distributed), and use different > method for installation (resulting in unnecessary install.sh) > - SUBSTITUTIONS are done automatically now through SUB_LIST w/ SUB_FILES, > and trim subsititions (some are not used) > - Don't install war file, as it isn't cleaned up properly when resin starts > - Remove resin.conf patch, in favor of REINPLACE_CMD > - Move installation from install.sh into port's Makefile > > PR: ports/165669 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=165669 > Submitted by: maintainer [1], jgh@ [2] > Approved by: maintainer, 5u623l20@gmail.com > Feature safe: yes > > Revision Changes Path > 1.45 +53 -96 ports/www/resin3/Makefile > 1.26 +2 -2 ports/www/resin3/distinfo > 1.6 +0 -55 ports/www/resin3/files/install.sh (dead) > 1.5 +0 -14 ports/www/resin3/files/patch-apache1-Makefile.in (dead) > 1.8 +4 -4 ports/www/resin3/files/patch-apache2-Makefile.in > 1.9 +17 -36 ports/www/resin3/files/patch-configure > 1.9 +0 -11 ports/www/resin3/files/patch-resin.conf (dead) > 1.2 +0 -52 ports/www/resin3/files/pkg-deinstall (dead) > 1.2 +0 -50 ports/www/resin3/files/pkg-install (dead) > 1.2 +0 -23 ports/www/resin3/files/pkg-message-advanced.in (dead) > 1.9 +33 -2 ports/www/resin3/files/pkg-message.in > 1.9 +0 -43 ports/www/resin3/files/resin.sh.in (dead) > 1.1 +43 -0 ports/www/resin3/files/resin3.sh.in (new) > 1.1 +188 -0 ports/www/resin3/files/resin3ctl.in (new) > 1.5 +0 -188 ports/www/resin3/files/resinctl (dead) > 1.23 +1047 -13 ports/www/resin3/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/Makefile.diff?&r1=1.44&r2=1.45&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/distinfo.diff?&r1=1.25&r2=1.26&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/install.sh > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/patch-apache1-Makefile.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/patch-apache2-Makefile.in.diff?&r1=1.7&r2=1.8&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/patch-configure.diff?&r1=1.8&r2=1.9&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/patch-resin.conf > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/pkg-deinstall > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/pkg-install > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/pkg-message-advanced.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/pkg-message.in.diff?&r1=1.8&r2=1.9&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/resin.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/resin3.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/resin3ctl.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/resinctl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/pkg-plist.diff?&r1=1.22&r2=1.23&f=u >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F6171E0.4010506>