From owner-svn-src-all@FreeBSD.ORG Tue Feb 9 19:18:10 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 371421065676; Tue, 9 Feb 2010 19:18:10 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout023.mac.com (asmtpout023.mac.com [17.148.16.98]) by mx1.freebsd.org (Postfix) with ESMTP id 1CC2A8FC19; Tue, 9 Feb 2010 19:18:09 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp023.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0KXL00BRQ9LNP390@asmtp023.mac.com>; Tue, 09 Feb 2010 11:17:48 -0800 (PST) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-0908210000 definitions=main-1002090179 From: Marcel Moolenaar In-reply-to: <20100209184043.GV9991@deviant.kiev.zoral.com.ua> Date: Tue, 09 Feb 2010 11:17:47 -0800 Message-id: <896B58E6-12EA-48AB-86C2-5BA9F0C59512@mac.com> References: <201002090552.o195qZcD074581@svn.freebsd.org> <20100209095722.GQ9991@deviant.kiev.zoral.com.ua> <65DCE552-7EFD-48F2-85A4-EA0F1F0638EE@mac.com> <20100209184043.GV9991@deviant.kiev.zoral.com.ua> To: Kostik Belousov X-Mailer: Apple Mail (2.1077) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r203696 - in head: lib/libc/sys sys/kern sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2010 19:18:10 -0000 On Feb 9, 2010, at 10:40 AM, Kostik Belousov wrote: *snip* Action items: >>> - vmspace should be referenced by vmspace_acquire_ref() >>> - vm_map should be read-locked before iterating the map entries. *snip* >> We can always put the timestamp in the structure. *snip* >> (2) the tracing process can check the timestamp returned by each >> request and compare that with the return value of the >> PT_VM_TIMESTAMP and restart the iteration. *snip* > I agree that #2 looks preferably, except that I consider it more > convenient when libc syscall wrapper return value is 0/-1 instead > of -1/some data. This means that timestamp might be added to > the existing struct ptrace_vm_entry. Of course. When I said returned, I didn't mean returned as the return value from ptrace. I used return to convey origin and direction of the information flow (see also the first sentence of my response :-) I'll implement it and send a patch for review to avoid unnecessary repository churn... Thanks! -- Marcel Moolenaar xcllnt@mac.com