From owner-svn-src-stable-10@FreeBSD.ORG Wed Oct 29 16:53:34 2014 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E47D2BFB; Wed, 29 Oct 2014 16:53:34 +0000 (UTC) Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198]) by mx1.freebsd.org (Postfix) with ESMTP id C503565A; Wed, 29 Oct 2014 16:53:34 +0000 (UTC) Received: from bender.lan (97e078e7.skybroadband.com [151.224.120.231]) by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id 824845C692; Wed, 29 Oct 2014 16:53:27 +0000 (UTC) Date: Wed, 29 Oct 2014 16:52:49 +0000 From: Andrew Turner To: Andrew Turner Subject: Re: svn commit: r273830 - stable/10/sys/arm/arm Message-ID: <20141029165249.046b8e8b@bender.lan> In-Reply-To: <201410291641.s9TGfLe3030937@svn.freebsd.org> References: <201410291641.s9TGfLe3030937@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 16:53:35 -0000 On Wed, 29 Oct 2014 16:41:21 +0000 (UTC) Andrew Turner wrote: > Author: andrew > Date: Wed Oct 29 16:41:20 2014 > New Revision: 273830 > URL: https://svnweb.freebsd.org/changeset/base/273830 > > Log: > MFC r273288: > > Allow the armv6 kernel to be build with PHYSADDR undefined. The > kernel will now find the virtual to physical mapping for libkvm to > use at runtime. This makes PHYSADDR redundant, however keep it around > to give everyone a chance to update their libkvm. ... > @@ -54,15 +66,21 @@ __FBSDID("$FreeBSD$"); > CPWAIT_BRANCH /* branch to next insn > */ > /* > - * This is for kvm_mkdb, and should be the address of the beginning > + * This is for libkvm, and should be the address of the beginning > * of the kernel text segment (not necessarily the same as kernbase). > + * > + * These are being phased out. Newer copies of libkvm don't need > these > + * values as the information is added to the core file by inspecting > + * the running kernel. > */ > .text > .align 0 > +#ifdef PHYSADDR > .globl kernbase > .set kernbase,KERNBASE > .globl physaddr > .set physaddr,PHYSADDR > +#endif While this is now an option PHYSADDR should be enabled on all kernel configs in this branch. It could be considered a POLA violation to have an old libkvm not work with a new kernel dump. This change just allows users to change their kernel config to not define PHYSADDR. Abndrew