From owner-freebsd-ports-bugs@freebsd.org  Wed Nov  1 12:41:55 2017
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84DE6E5AC0A
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Wed,  1 Nov 2017 12:41:55 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 72EDF6D018
 for <freebsd-ports-bugs@FreeBSD.org>; Wed,  1 Nov 2017 12:41:55 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vA1CfsM0096296
 for <freebsd-ports-bugs@FreeBSD.org>; Wed, 1 Nov 2017 12:41:55 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 223361] amsynth port
Date: Wed, 01 Nov 2017 12:41:55 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: adamw@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-223361-13-2hzLyl1MC2@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-223361-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-223361-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Nov 2017 12:41:55 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223361

Adam Weinberger <adamw@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adamw@FreeBSD.org

--- Comment #2 from Adam Weinberger <adamw@FreeBSD.org> ---
You're off to a good start here, but there's still lots to be done.

NLS needs to be an option. See
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile=
-options.html
for more details. Either way, your PLIST_SUB is unused, given that you have=
 no
%%NLS%% tags in the pkg-plist.

The post-extract is wrong. You're calling commands that haven't been instal=
led
yet, which leads me to suspect that you haven't tested this in poudriere, w=
hich
is a requirement of all submissions. Add USES=3Dautoreconf instead and remo=
ve
that entire post-extract block.

The pre.mk/post.mk is unused here. Just call ".include <bsd.port.mk>" at the
end.

Once you've fixed up those issues, test it in "poudriere testport" and
"portlint -AC" and attach the output of both.

--=20
You are receiving this mail because:
You are the assignee for the bug.=