From owner-svn-src-stable-8@FreeBSD.ORG Wed Nov 24 10:55:46 2010 Return-Path: Delivered-To: svn-src-stable-8@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 464821065673; Wed, 24 Nov 2010 10:55:46 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id A27048FC12; Wed, 24 Nov 2010 10:55:45 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.4/8.14.4) with ESMTP id oAOATM7q011732; Wed, 24 Nov 2010 13:29:22 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.4/8.14.4/Submit) id oAOATMvM011730; Wed, 24 Nov 2010 13:29:22 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 24 Nov 2010 13:29:22 +0300 From: Gleb Smirnoff To: Bruce Evans Message-ID: <20101124102922.GP98817@FreeBSD.org> References: <201011240537.oAO5bCSC056347@svn.freebsd.org> <20101124175843.I1829@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20101124175843.I1829@besplex.bde.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org Subject: Re: svn commit: r215791 - stable/8/sys/netinet X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 10:55:46 -0000 On Wed, Nov 24, 2010 at 06:11:53PM +1100, Bruce Evans wrote: B> > +++ stable/8/sys/netinet/if_ether.c Wed Nov 24 05:37:12 2010 (r215791) B> > @@ -381,7 +381,7 @@ retry: B> > int canceled; B> > B> > LLE_ADDREF(la); B> > - la->la_expire = time_second + V_arpt_down; B> > + la->la_expire = time_second; B> > canceled = callout_reset(&la->la_timer, hz * V_arpt_down, B> > arptimer, la); B> > if (canceled) B> > B> B> Isn't using non-monotic time for timeouts always wrong? Sure it is wrong. I never payed attention to that fact that time_second could be non-monotic. Is it non-monotic? I failed to understand kern_tc code at first glance. B> There are lots of other time_second's in networkining code. These B> still outnumber time_uptime's by about 68:41. rtcock.c uses the weird B> expression time_second - time_uptime for metrics. Since time_uptime B> is relative to boot time while time_second is relative to the Epoch, B> their difference is approximately the number of seconds since the B> Epoch, which is a very strange value which might nevertheless be B> useful for converting between monotonic expiry times and real expiry B> times, but I think it doesn't work even for that if the real time is B> stepped. B> B> Bruce -- Totus tuus, Glebius.