From nobody Thu Sep 14 22:42:15 2023 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RmslD4gVxz4snHC for ; Thu, 14 Sep 2023 22:42:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RmslD14N9z3QWW for ; Thu, 14 Sep 2023 22:42:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694731336; a=rsa-sha256; cv=none; b=IifffU9zeMzd/BstJvHIn0i2rZaneDcTuNxERnYb5vu3pTNN/xCeneoyxDoYT16A+230ae DncOZkVVEkP5V8YCJapQkW7Zxg6UehMxZ2fexkJMyUCBzZ0VqsewIfuU0UFSqSYvVlPOGy vHVyAVd7kn8zyA/FDCryxpaT+LpKUuhPV4ZFBT8whDwuMdXyQIJr//1A2QsEH4vE9aOQMN AVWpqsj1xt3z8qpWWJQiTn6SLwTepmgoCVxxaOVJC7TAI2sJGlBw58WCJTAyGb9jV09gev oitx8EZqpOkLLzBq/w/7iErUXYKcfhGVjT+tC1d84a8ofxO36RpzNPl+6ZyZWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694731336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uaIA2L3nVXE+/nmT2wikl9NeUhFsrl1Jl81fZGbSLa0=; b=EKHfVMN6E5FonzCgXwtaVZIdxuSyq/0s90W3i2BeOkk+Thic1i/FialzHZL4ZRbV8VrZ5r p1jx/aVFseRwmn/ksPyR0A9o1OfiBLkEZCE1bhA8Z1iqIvVudT+3sAe7dg/cGqI2g9+4Wi mwCTmjG9eJsiyNoKoxfjTsH7YyChiye7WgOKVOgeN+A2My3AaWfNFrszW9+VfS2v9KiI34 NSB3a3Lpg+3igvM9H/kIdYxpE5+s5UVD+7KLDwC6MDb8c7bA1cb+5F0F3H2QL291xThXtf q9Z13EH8sU3iO7zWgXWtH+sy3t1+UlVjym67kXCVPcoXWsQ2t46vARdH3c6WeQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RmslD010yz1F8s for ; Thu, 14 Sep 2023 22:42:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38EMgFsp021513 for ; Thu, 14 Sep 2023 22:42:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38EMgFO8021512 for x11@FreeBSD.org; Thu, 14 Sep 2023 22:42:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 273806] x11/libXcursor: Avoid duplicated path in XCURSORPATH Date: Thu, 14 Sep 2023 22:42:15 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc blocked flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273806 Bug ID: 273806 Summary: x11/libXcursor: Avoid duplicated path in XCURSORPATH Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: x11@FreeBSD.org Reporter: madpilot@FreeBSD.org CC: x11@FreeBSD.org Blocks: 273744 Flags: maintainer-feedback?(x11@FreeBSD.org) Assignee: x11@FreeBSD.org Attachment #244858 maintainer-approval?(x11@FreeBSD.org) Flags: Flags: maintainer-feedback?(x11@FreeBSD.org), merge-quarterly? CC: x11@FreeBSD.org Created attachment 244858 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D244858&action= =3Dedit patch v1 by default libXcursor is being build passing to it an ICONDIR that causes t= he configure script to define an XCURSORPATH with that value duplicated. This = can be seen in any build log, the cc commands get this argument: -DXCURSORPATH=3D\"~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr= /local/share/pixmaps:/usr/local/share/icons\" This is causing issues with xfce4-mouse-settings from xfce4-settings port, which scans this path for cursor themes. This software performs no checks f= or duplicates, so cursor themes are duplicated in the UI. The details of this are in bug #273744 I have checked the configure script, which has some simple check to try to = avid such duplicates, but actually fails due to variable substitutions being performed in multiple steps and the check for equal variables fails to catch our path. So, to avoid this, I thought we could directly pass the full xcursor search path with the configure --with-cursorpath variable, so we have full control over it. Testing in poudriere shows it does what it is expected, I'm going to run te= st it on my machines as soon the build run ends. Can this be approved? Thanks in advance. Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273744 [Bug 273744] sysutils/xfce4-settings: cursor themes being listed twice --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=