From owner-freebsd-acpi@FreeBSD.ORG Thu Sep 6 22:17:22 2007 Return-Path: Delivered-To: acpi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B21016A419 for ; Thu, 6 Sep 2007 22:17:22 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 47EFC13C46B for ; Thu, 6 Sep 2007 22:17:22 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 68262 invoked from network); 6 Sep 2007 22:17:23 -0000 Received: from ppp-71-139-1-224.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.1.224) by root.org with ESMTPA; 6 Sep 2007 22:17:23 -0000 Message-ID: <46E07AAF.2060000@root.org> Date: Thu, 06 Sep 2007 15:09:51 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: current@FreeBSD.org References: <46E0777A.8070901@root.org> In-Reply-To: <46E0777A.8070901@root.org> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: acpi@FreeBSD.ORG Subject: Re: PATCH: ecng for 6.x and 7.x X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2007 22:17:22 -0000 Nate Lawson wrote: > I've done some major rework on the EC driver. This should help with > various problems, including timeouts while checking battery status or > temperature. The attached patches are for 6.x and 7.x. Please test and > let me know if you get any new errors on dmesg or if it fixes things for > you (especially HP/Compaq laptop owners). > > If you still have problems, try setting each of these tunables > individually and then both together (i.e., in /boot/loader.conf). Note > that this will be four (4) test runs total, so don't just set both and > say it doesn't work. > > debug.acpi.ec.burst="1" > debug.acpi.ec.polled="1" > > I've tested both patches on a Panasonic Y4 and UnnamedOEM laptop, no > problems in either regular or burst mode. > > > Commit message: > Rewrite the EC driver event model. The main goal is to avoid > polling/interrupt-driven fallback and instead use polling only during > boot and pure interrupt-driven mode after boot. Polled mode could be > relegated completely to a legacy role if we could enable interrupts > during boot. Polled mode can be forced after boot by setting > debug.acpi.ec.polled="1", i.e. if there are timeouts. One minor note -- power off shutdown (shutdown/halt -p) is turned into a (safe) reboot with this patch. I have tested the fix, which is just to force polled mode during shutdown as well. I don't have time to re-roll the patch today but will send tomorrow. Please test the patch as posted, ignoring that minor issue. The test results during normal use are still valid. -- Nate