From owner-svn-src-head@freebsd.org  Tue Jan 12 15:28:00 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A58F9A6D2BA;
 Tue, 12 Jan 2016 15:28:00 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 9B487124B;
 Tue, 12 Jan 2016 15:28:00 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 994911DDC; Tue, 12 Jan 2016 15:28:00 +0000 (UTC)
Date: Tue, 12 Jan 2016 15:28:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ian Lepore <ian@freebsd.org>
Cc: Joel Dahl <joel@vnode.se>, Sepherosa Ziehau <sephe@FreeBSD.org>,
 svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
Subject: Re: svn commit: r293720 - head/sys/dev/hyperv/netvsc
Message-ID: <20160112152800.GA94850@FreeBSD.org>
References: <201601120141.u0C1fYbC080237@repo.freebsd.org>
 <20160112075525.GA38087@ymer.vnode.se>
 <1452609005.46848.11.camel@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452609005.46848.11.camel@freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 15:28:00 -0000

On Tue, Jan 12, 2016 at 07:30:05AM -0700, Ian Lepore wrote:
> On Tue, 2016-01-12 at 08:55 +0100, Joel Dahl wrote:
> > On Tue, Jan 12, 2016 at 01:41:34AM +0000, Sepherosa Ziehau wrote:
> > > Author: sephe
> > > Date: Tue Jan 12 01:41:34 2016
> > > New Revision: 293720
> > > URL: https://svnweb.freebsd.org/changeset/base/293720
> > > 
> > > [...]
> > >   Modified by:		me (minor)
> > 
> > % finger me@freebsd.org
> > [freebsd.org]
> > Trying 8.8.178.110...
> > Login: me             			Name: Michael Elbel
> 
> Really?  You're complaining about the committer using the personal
> pronoun that refers to one's self in a context of referring to himself?

I understand you; with certain entries like `me' or `myself' it does look
silly indeed, however...

> Do we really, as a project, have nothing better to do than this endless
> nitpicking at the metadata in commit messages?

... many of us neglect to give enough thinking and thus often give bogus
attribution in the logs; while complaining over personal pronouns is off
the line, the problem still stands, and I'm glad that people are paying
attention to these things.  Please don't be hard on Joel.

Generally, "Submitted by: foo (modified)" should be enough metadata to
reflect the fact that submitted changes were not applied verbatim; which
in turn is appropriate amendment for more of less substantial changes,
trivial modifications do not warrant it.

./danfe