From owner-cvs-all Thu Nov 18 11:20:11 1999 Delivered-To: cvs-all@freebsd.org Received: from jade.chc-chimes.com (jade.chc-chimes.com [216.28.46.6]) by hub.freebsd.org (Postfix) with ESMTP id 307C0154A1; Thu, 18 Nov 1999 11:19:45 -0800 (PST) (envelope-from billf@chc-chimes.com) Received: by jade.chc-chimes.com (Postfix, from userid 1001) id DEE291C5A; Thu, 18 Nov 1999 13:21:16 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by jade.chc-chimes.com (Postfix) with ESMTP id DB5BE381B; Thu, 18 Nov 1999 13:21:16 -0500 (EST) Date: Thu, 18 Nov 1999 13:21:16 -0500 (EST) From: Bill Fumerola To: Matthew Dillon Cc: Nick Hibma , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c vfs_vnops.c In-Reply-To: <199911181814.KAA86275@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, 18 Nov 1999, Matthew Dillon wrote: > I don't consider a simple PR reference to be proper credit, so I > put Kelly's name in the Submitted by: field (since he did submit it), > and since I reviewed it I put my name in the Reviewed by: field. > Sounds right to me. This has been discussed before. There is a long mail I sent out, but to summarize: All of those fields all pretty much mean "if it wasn't you". Hence, when I make a commit I don't say " Add a dependency to libfoo Submitted by: billf Reviewed by: billf " It's redundant. If you're committing, it's assumed you have reviewed the code. -- - bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp - - ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org - To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message