From owner-cvs-src-old@FreeBSD.ORG Mon Jun 21 22:01:12 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67A081065791 for ; Mon, 21 Jun 2010 22:01:12 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 52C6A8FC08 for ; Mon, 21 Jun 2010 22:01:12 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5LM1Cri090318 for ; Mon, 21 Jun 2010 22:01:12 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5LM1CuB090317 for cvs-src-old@freebsd.org; Mon, 21 Jun 2010 22:01:12 GMT (envelope-from delphij@repoman.freebsd.org) Message-Id: <201006212201.o5LM1CuB090317@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to delphij@repoman.freebsd.org using -f From: Xin LI Date: Mon, 21 Jun 2010 22:00:57 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/sys/dev/twa tw_cl.h tw_cl_fwif.h tw_cl_init.c tw_cl_intr.c tw_cl_io.c tw_cl_misc.c tw_cl_share.h tw_osl.h tw_osl_cam.c tw_osl_externs.h tw_osl_freebsd.c tw_osl_inline.h tw_osl_share.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2010 22:01:12 -0000 delphij 2010-06-21 22:00:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sys/dev/twa tw_cl.h tw_cl_fwif.h tw_cl_init.c tw_cl_intr.c tw_cl_io.c tw_cl_misc.c tw_cl_share.h tw_osl.h tw_osl_cam.c tw_osl_externs.h tw_osl_freebsd.c tw_osl_inline.h tw_osl_share.h Log: SVN rev 209404 on 2010-06-21 22:00:57Z by delphij MFC r208969,209268: Driver update of twa(4) from LSI. Many thanks to LSI for continuing to support FreeBSD. 1) Timeout ioctl command timeouts. Do not reset the controller if ioctl command completed successfully. 2) Remove G66_WORKAROUND code (this bug never shipped). 3) Remove unnecessary interrupt lock (intr_lock). 4) Timeout firmware handshake for PChip reset (don't wait forever). 5) Handle interrupts inline. 6) Unmask command interrupt ONLY when adding a command to the pending queue. 7) Mask command interrupt ONLY after removing the last command from the pending queue. 8) Remove TW_OSLI_DEFERRED_INTR_USED code. 9) Replace controller "state" with separate data fields to avoid races: TW_CLI_CTLR_STATE_ACTIVE ctlr->active TW_CLI_CTLR_STATE_INTR_ENABLED ctlr->interrupts_enabled TW_CLI_CTLR_STATE_INTERNAL_REQ_BUSY ctlr->internal_req_busy TW_CLI_CTLR_STATE_GET_MORE_AENS ctlr->get_more_aens TW_CLI_CTLR_STATE_RESET_IN_PROGRESS ctlr->reset_in_progress TW_CLI_CTLR_STATE_RESET_PHASE1_IN_PROGRESS ctlr->reset_phase1_in_progress 10) Fix "req" leak in twa_action() when simq is frozen and req is NOT null. 11) Replace softc "state" with separate data fields to avoid races: TW_OSLI_CTLR_STATE_OPEN sc->open TW_OSLI_CTLR_STATE_SIMQ_FROZEN sc->simq_frozen 12) Fix reference to TW_OSLI_REQ_FLAGS_IN_PROGRESS in tw_osl_complete_passthru() 13) Use correct CAM status values. Change CAM_REQ_CMP_ERR to CAM_REQ_INVALID. Remove use of CAM_RELEASE_SIMQ for physical data addresses. 14) Do not freeze/ release the simq with non I/O commands. When it is appropriate to temporarily freeze the simq with an I/O command use: xpt_freeze_simq(sim, 1); ccb->ccb_h.status |= CAM_RELEASE_SIMQ; otherwise use: xpt_freeze_simq(sim, 1); xpt_release_simq(sim, 1); Submitted by: Tom Couch PR: kern/147695 Revision Changes Path 1.3.10.2 +6 -21 src/sys/dev/twa/tw_cl.h 1.3.10.2 +1 -2 src/sys/dev/twa/tw_cl_fwif.h 1.5.2.2 +13 -47 src/sys/dev/twa/tw_cl_init.c 1.4.10.2 +23 -98 src/sys/dev/twa/tw_cl_intr.c 1.4.10.2 +58 -52 src/sys/dev/twa/tw_cl_io.c 1.4.10.2 +9 -38 src/sys/dev/twa/tw_cl_misc.c 1.4.10.2 +2 -11 src/sys/dev/twa/tw_cl_share.h 1.7.2.2 +7 -11 src/sys/dev/twa/tw_osl.h 1.12.10.3 +24 -74 src/sys/dev/twa/tw_osl_cam.c 1.2.10.2 +2 -4 src/sys/dev/twa/tw_osl_externs.h 1.14.2.2 +49 -95 src/sys/dev/twa/tw_osl_freebsd.c 1.3.10.2 +0 -15 src/sys/dev/twa/tw_osl_inline.h 1.9.10.2 +1 -1 src/sys/dev/twa/tw_osl_share.h