From owner-svn-soc-all@freebsd.org Sun May 29 18:40:21 2016 Return-Path: Delivered-To: svn-soc-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D4EAB54CAB for ; Sun, 29 May 2016 18:40:21 +0000 (UTC) (envelope-from iateaca@FreeBSD.org) Received: from socsvn.freebsd.org (socsvn.freebsd.org [IPv6:2001:1900:2254:206a::50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2047F14B4 for ; Sun, 29 May 2016 18:40:21 +0000 (UTC) (envelope-from iateaca@FreeBSD.org) Received: from socsvn.freebsd.org ([127.0.1.124]) by socsvn.freebsd.org (8.15.2/8.15.2) with ESMTP id u4TIeKEQ006095 for ; Sun, 29 May 2016 18:40:20 GMT (envelope-from iateaca@FreeBSD.org) Received: (from www@localhost) by socsvn.freebsd.org (8.15.2/8.15.2/Submit) id u4TIeKW1006036 for svn-soc-all@FreeBSD.org; Sun, 29 May 2016 18:40:20 GMT (envelope-from iateaca@FreeBSD.org) Date: Sun, 29 May 2016 18:40:20 GMT Message-Id: <201605291840.u4TIeKW1006036@socsvn.freebsd.org> X-Authentication-Warning: socsvn.freebsd.org: www set sender to iateaca@FreeBSD.org using -f From: iateaca@FreeBSD.org To: svn-soc-all@FreeBSD.org Subject: socsvn commit: r304168 - soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-soc-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the entire Summer of Code repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 May 2016 18:40:21 -0000 Author: iateaca Date: Sun May 29 18:40:19 2016 New Revision: 304168 URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=304168 Log: run corb mechanism in loop while rp != wp increment corp rp pointer and turn to 0 when rp = corb->size M bhyve/pci_hda.c Modified: soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c Modified: soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c ============================================================================== --- soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c Sun May 29 17:35:38 2016 (r304167) +++ soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c Sun May 29 18:40:19 2016 (r304168) @@ -432,6 +432,24 @@ static int hda_corb_run(struct hda_softc *sc) { + struct hda_codec_cmd_ctl *corb = &sc->corb; + uint32_t verb = 0; + int err; + + corb->wp = hda_get_reg_by_offset(sc, HDAC_CORBWP); + + while (corb->rp != corb->wp && corb->run) { + corb->rp++; + corb->rp %= corb->size; + + verb = hda_dma_ld_dword(corb->dma_vaddr + HDA_CORB_ENTRY_LEN * corb->rp); + + err = hda_send_command(sc, verb); + assert(!err); + } + + hda_set_reg_by_offset(sc, HDAC_CORBRP, corb->rp); + return 0; } @@ -521,25 +539,7 @@ static void hda_set_corbwp(struct hda_softc *sc, uint32_t offset, uint32_t old) { - struct hda_codec_cmd_ctl *corb = &sc->corb; - uint32_t value = sc->regs[offset]; - uint32_t verb = 0; - int err; - - corb->wp = value; - - /* - * TODO do it in loop - */ - if (corb->wp != corb->rp && corb->run) { - corb->rp++; - verb = hda_dma_ld_dword(corb->dma_vaddr + HDA_CORB_ENTRY_LEN * corb->rp); - - err = hda_send_command(sc, verb); - assert(!err); - } - - hda_set_reg_by_offset(sc, HDAC_CORBRP, corb->rp); + hda_corb_run(sc); return; }