From owner-freebsd-current Thu Nov 19 01:58:28 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA09864 for freebsd-current-outgoing; Thu, 19 Nov 1998 01:58:28 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ceia.nordier.com (m2-56-dbn.dial-up.net [196.34.155.120]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA09856 for ; Thu, 19 Nov 1998 01:58:11 -0800 (PST) (envelope-from rnordier@nordier.com) Received: (from rnordier@localhost) by ceia.nordier.com (8.8.7/8.6.12) id LAA04596; Thu, 19 Nov 1998 11:56:25 +0200 (SAT) From: Robert Nordier Message-Id: <199811190956.LAA04596@ceia.nordier.com> Subject: Re: snprintf() in the kernel In-Reply-To: <199811190712.XAA23068@bubba.whistle.com> from Archie Cobbs at "Nov 18, 98 11:12:24 pm" To: archie@whistle.com (Archie Cobbs) Date: Thu, 19 Nov 1998 11:56:18 +0200 (SAT) Cc: freebsd-current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL31 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Archie Cobbs wrote: > I would like to do the following: > > 1. Add snprintf() to kern/subr_prf.c > > 2. Change all appropriate uses of sprintf() and/or strcat() > to use snprintf() instead. > > The main reason for doing this is not to add kernel bloat :-) but > rather to improve the reliability and maintainability of the kernel. [...] > So.. does anyone have a huge problem with doing this before I jump in? > [ Anyone willing to review for me? ] Seems mainly an issue of more appropriate coding. I think it's a win, and would be willing to double-check the changes. -- Robert Nordier To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message