Date: Thu, 31 Jul 1997 02:28:03 -0700 (PDT) From: Satoshi Asami <asami@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG Subject: cvs commit: ports/x11/tk41 Makefile ports/x11/tk41/files Makefile.lib ports/x11/tk41/patches patch-ab patch-ac ports/x11/tk41/pkg PLIST Message-ID: <199707310928.CAA19745@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
asami 1997/07/31 02:28:02 PDT
Modified files:
x11/tk41 Makefile
x11/tk41/files Makefile.lib
x11/tk41/patches patch-ab patch-ac
x11/tk41/pkg PLIST
Log:
Fix this up so it properly packages and uninstalls (using pkg_delete).
It's not a good idea to commit a port without testing at least "make
package" and "pkg_delete `make package-name`".
Also, there were several quite embarrasing bogons:
@ The comment at top of Makefile said version is 4.2
@ Patches the source all over the place instead of using the flag
"--with-tcl" to configure (like the previous revision did) - (*)
@ Patches to unused configure.in, etc.
@ Instead of installing the subset of internal headers that are
necessary (it is clearly stated in the log of Makefile why those
were chosen), blindly installing all of them (and even forgetting
to update PLIST for that)
@ Deleting the "default" rule for no good reason (however, it is
clear how this happened...it is because the tk42 Makefile was
copied over without enough inspection)
In other words, a working port was turned into a non-working one by
blindly splatting the tk42 port all over it. I wasted two hours of my
time fixing it up. I really hate this, and would have just backed out
all changes if it weren't mixed with an upgrade. :(
Note this port uses tcl75 in the system again. It may be possible to
get it to use a tcl75 installation in /usr/local quite easily (see *
above), but I can't try it here.
Revision Changes Path
1.14 +12 -28 ports/x11/tk41/Makefile
1.3 +0 -1 ports/x11/tk41/files/Makefile.lib
1.4 +9 -42 ports/x11/tk41/patches/patch-ab
1.4 +3 -30 ports/x11/tk41/patches/patch-ac
1.9 +2 -0 ports/x11/tk41/pkg/PLIST
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199707310928.CAA19745>