From nobody Wed May 27 14:59:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQXp60wfZz6f8pf for ; Wed, 27 May 2026 14:59:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQXp52lZNz3HX7 for ; Wed, 27 May 2026 14:59:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779893965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P9lDJELIgFGVdpqTnQK2oCoK+ByZxzMEbvRmpp3wSVg=; b=fwLaPBoCKOghxcqNscIICKaJGq8waywHC9JtGUgsnnm6HsN20Rv5TsoSw0rg0X+d+OMCjZ 4RpomHSceeSgOhr98SWtqILtol+pxZToL20RD+a3qv3CUD5hRjYHe7slfVxDOutPm3aScM 7SKMmvKRPKIk506AcKmrJ0W7IKmwjv12rp5uGe6idUvs5orgFtUE2HL6tgsgZaftPuc399 RyJa7kr37MCYMIs9zH3fUO001lao6X05sFX4KrTx+NwrhMUcPBl3EmVvoyWLYp0mUg1xGG N03XMa/6ty3koT0S/37kHv5AQ3BHMWMXsNLeScc7y7bNc4PBzadUyb8+HfGgvA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779893965; a=rsa-sha256; cv=none; b=VkCFIocA8sthHoH+gDAJuS6YdqZ1nMy/lPnqnHzZvK1tmnADbIwtcAfh02CeG86MxqIOHi GNTyv696Plp9GmzRsj6sfWU8erJWsgIufyKbcvVbyNGwThTRuRsX5tsCiZQFp5laXMTgVc Zhx+U17gmkpcaq/eM3J2zjTzG3dzeuSzTyfPcrOYk5QrTSKCeZeGY+Hm/VOhwHKvknqOTv +cFIF7hpTaj/nv6Qc1UTk1RHrd3kAlJC/DSSFNNiQuqjidFDmO8LtQL6WjulRG3nMjlvzQ nUeMNMVWc36MzNviu8v6CsCDrM1mSvGDGagJDC42iABAR2CfYD2+E1YRYwGGFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779893965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P9lDJELIgFGVdpqTnQK2oCoK+ByZxzMEbvRmpp3wSVg=; b=ypTq4OCYOBIc5uvsJMj5YRr9Eso/YXaC0I5QKx3jWBltcxlevxFG9MUv1coLzHFGwIAISk 40Ai8d2Uw6SKcQn0qTrNZw1RU99ym0mb88yH/8tTZarrdJpU1LWrCuQDBFKFAbqI96wd9H weEkn9HKgTEb3RIsRjh1Y1c9Mh9pyfKHPin0bX4Bsv0BAT2HCqQLNHCRCUiatVnBBHowLD vAArfubTbxHIE1kkAPJQWNcNbROtE8rNCwtnylFz5dw/i+CiSEYka0bDKJXbyw6QSAp2tr 8kFIa+dsaLIEjxt8/VEpE67Hwzvw+kcF3cPzYtF9ud5DtusYKGht+n8DpOy0dw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQXp522Fbz1462 for ; Wed, 27 May 2026 14:59:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 246ad by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 14:59:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: f7524d8fcbd7 - main - amd64: Inline set_top_of_stack_td into cpu_thread_new_kstack List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f7524d8fcbd76a432c163200a7c77ce964805beb Auto-Submitted: auto-generated Date: Wed, 27 May 2026 14:59:25 +0000 Message-Id: <6a1706cd.246ad.1498e044@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=f7524d8fcbd76a432c163200a7c77ce964805beb commit f7524d8fcbd76a432c163200a7c77ce964805beb Author: John Baldwin AuthorDate: 2026-05-05 14:43:10 +0000 Commit: John Baldwin CommitDate: 2026-05-27 13:45:25 +0000 amd64: Inline set_top_of_stack_td into cpu_thread_new_kstack Reviewed by: kib Sponsored by: AFRL, DARPA Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/23 --- sys/amd64/amd64/machdep.c | 2 +- sys/amd64/amd64/vm_machdep.c | 10 ++-------- sys/amd64/include/md_var.h | 1 - 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/sys/amd64/amd64/machdep.c b/sys/amd64/amd64/machdep.c index 20c4be7880ff..510c6d375a2d 100644 --- a/sys/amd64/amd64/machdep.c +++ b/sys/amd64/amd64/machdep.c @@ -1369,6 +1369,7 @@ hammer_time(u_int64_t modulep, u_int64_t physfree) thread0.td_kstack_pages = kstack_pages; kstack0_sz = thread0.td_kstack_pages * PAGE_SIZE; bzero(thread0.td_kstack, kstack0_sz); + cpu_thread_new_kstack(&thread0); physfree += kstack0_sz; /* @@ -1521,7 +1522,6 @@ hammer_time(u_int64_t modulep, u_int64_t physfree) * We initialize the PCB pointer early so that exception * handlers will work. */ - set_top_of_stack_td(&thread0); thread0.td_pcb = get_pcb_td(&thread0); /* diff --git a/sys/amd64/amd64/vm_machdep.c b/sys/amd64/amd64/vm_machdep.c index 2df53285d71d..244d82ee8ebb 100644 --- a/sys/amd64/amd64/vm_machdep.c +++ b/sys/amd64/amd64/vm_machdep.c @@ -83,13 +83,6 @@ _Static_assert(OFFSETOF_MONITORBUF == offsetof(struct pcpu, pc_monitorbuf), "OFFSETOF_MONITORBUF does not correspond with offset of pc_monitorbuf."); -void -set_top_of_stack_td(struct thread *td) -{ - td->td_md.md_stack_base = td->td_kstack + - td->td_kstack_pages * PAGE_SIZE; -} - struct savefpu * get_pcb_user_save_td(struct thread *td) { @@ -384,7 +377,8 @@ cpu_thread_alloc(struct thread *td) void cpu_thread_new_kstack(struct thread *td) { - set_top_of_stack_td(td); + td->td_md.md_stack_base = td->td_kstack + + td->td_kstack_pages * PAGE_SIZE; td->td_frame = (struct trapframe *)td->td_md.md_stack_base - 1; } diff --git a/sys/amd64/include/md_var.h b/sys/amd64/include/md_var.h index 46a30518b212..4b98c5d8c418 100644 --- a/sys/amd64/include/md_var.h +++ b/sys/amd64/include/md_var.h @@ -94,7 +94,6 @@ void gsbase_load_fault(void) __asm(__STRING(gsbase_load_fault)); void fpstate_drop(struct thread *td); void pagezero(void *addr); void setidt(int idx, alias_for_inthand_t *func, int typ, int dpl, int ist); -void set_top_of_stack_td(struct thread *td); struct savefpu *get_pcb_user_save_td(struct thread *td); struct savefpu *get_pcb_user_save_pcb(struct pcb *pcb); void pci_early_quirks(void);