From owner-svn-src-head@freebsd.org  Tue Sep 22 09:53:49 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBC8DA06DD3;
 Tue, 22 Sep 2015 09:53:49 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "tensor.andric.com",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E2E41E65;
 Tue, 22 Sep 2015 09:53:49 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from [10.192.0.157] (unknown [178.20.49.58])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 109D41A3D8;
 Tue, 22 Sep 2015 11:53:39 +0200 (CEST)
Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Content-Type: multipart/signed;
 boundary="Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C";
 protocol="application/pgp-signature"; micalg=pgp-sha1
X-Pgp-Agent: GPGMail 2.5.1
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <20150922094301.GW3158@zxy.spb.ru>
Date: Tue, 22 Sep 2015 11:53:32 +0200
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Message-Id: <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org>
References: <201509220935.t8M9ZZfD051027@repo.freebsd.org>
 <20150922094301.GW3158@zxy.spb.ru>
To: Slawa Olhovchenkov <slw@zxy.spb.ru>
X-Mailer: Apple Mail (2.2104)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 09:53:50 -0000


--Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 22 Sep 2015, at 11:43, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote:
> 
> On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote:
...
>> -			  imm |= (-1 << 7);
>> +			  imm |= -(1 << 7);
> 
> May be (~0 << 7) is more simple to understund?

This will give the same warning.  ~0 will implicitly convert to -1.

(It would be better to convert all these masks to unsigned, where such
shifting is always defined, but that gives a lot more churn.)

-Dimitry


--Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.28

iEYEARECAAYFAlYBJSEACgkQsF6jCi4glqP+rwCfTjg7PsgHQ+CGzXK0mjDocs8M
sKkAoOjYCBgJzCqOE4MsaKx0ohV7F3Fg
=2SDb
-----END PGP SIGNATURE-----

--Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C--