Date: Tue, 22 Sep 2015 11:53:32 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes Message-ID: <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org> In-Reply-To: <20150922094301.GW3158@zxy.spb.ru> References: <201509220935.t8M9ZZfD051027@repo.freebsd.org> <20150922094301.GW3158@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 22 Sep 2015, at 11:43, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote: > > On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote: ... >> - imm |= (-1 << 7); >> + imm |= -(1 << 7); > > May be (~0 << 7) is more simple to understund? This will give the same warning. ~0 will implicitly convert to -1. (It would be better to convert all these masks to unsigned, where such shifting is always defined, but that gives a lot more churn.) -Dimitry --Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.28 iEYEARECAAYFAlYBJSEACgkQsF6jCi4glqP+rwCfTjg7PsgHQ+CGzXK0mjDocs8M sKkAoOjYCBgJzCqOE4MsaKx0ohV7F3Fg =2SDb -----END PGP SIGNATURE----- --Apple-Mail=_F36ED1AA-2892-4258-B119-35DFAF35432C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CD0DC75-0235-4890-827C-4FF41BBADD8A>